Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
app/services/admin2/testimonials_service.rb

Summary

Maintainability
C
1 day
Test Coverage

Class TestimonialsService has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class Admin2::TestimonialsService
  attr_reader :community, :params

  def initialize(community:, params:)
    @params = params
Severity: Minor
Found in app/services/admin2/testimonials_service.rb - About 2 hrs to fix

    Method filtered_scope has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def filtered_scope
    return @filtered_scope if defined?(@filtered_scope)

    scope = transactions_scope
    Severity: Minor
    Found in app/services/admin2/testimonials_service.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method count_by_status has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def count_by_status(status = nil)
    scope = transactions_scope
    tx_statuses = []
    tx_statuses.push(Transaction.skipped_feedback) if status == 'skipped'
    tx_statuses.push(Transaction.waiting_feedback) if status == 'waiting'
    Severity: Minor
    Found in app/services/admin2/testimonials_service.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method filtered_scope has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def filtered_scope
    return @filtered_scope if defined?(@filtered_scope)

    scope = transactions_scope
    Severity: Minor
    Found in app/services/admin2/testimonials_service.rb - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        def filtered_scope
    return @filtered_scope if defined?(@filtered_scope)

    scope = transactions_scope
      Severity: Major
      Found in app/services/admin2/testimonials_service.rb and 1 other location - About 3 hrs to fix
      app/services/admin/testimonials_service.rb on lines 102..132

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        def testimonials
    return @testimonials if defined?(@testimonials)

    pages = transactions.total_pages
    tx_from = transactions.offset + 1
      Severity: Minor
      Found in app/services/admin2/testimonials_service.rb and 1 other location - About 1 hr to fix
      app/services/admin/testimonials_service.rb on lines 15..27

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def update_provider_rating
    return unless params[:provider_rating].present?

    testimonial = transaction.testimonial_from_author || new_testimonial
    testimonial.author = transaction.author
      Severity: Minor
      Found in app/services/admin2/testimonials_service.rb and 1 other location - About 35 mins to fix
      app/services/admin2/testimonials_service.rb on lines 84..92

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def update_customer_rating
    return unless params[:customer_rating].present?

    testimonial = transaction.testimonial_from_starter || new_testimonial
    testimonial.author = transaction.starter
      Severity: Minor
      Found in app/services/admin2/testimonials_service.rb and 1 other location - About 35 mins to fix
      app/services/admin2/testimonials_service.rb on lines 111..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status