Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
app/services/paypal_service/data_types/ipn.rb

Summary

Maintainability
D
2 days
Test Coverage

File ipn.rb has 468 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module PaypalService

  Invnum = PaypalService::API::Invnum

  module DataTypes
Severity: Minor
Found in app/services/paypal_service/data_types/ipn.rb - About 7 hrs to fix

    Method msg_type has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

          def msg_type(txn_type, payment_status, pending_reason, invoice_num)
        txn_type = txn_type.to_s.downcase
        status, reason = payment_status.to_s.downcase, pending_reason.to_s.downcase
        inv_type = Invnum.type(invoice_num) if invoice_num
    Severity: Minor
    Found in app/services/paypal_service/data_types/ipn.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method msg_type has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def msg_type(txn_type, payment_status, pending_reason, invoice_num)
        txn_type = txn_type.to_s.downcase
        status, reason = payment_status.to_s.downcase, pending_reason.to_s.downcase
        inv_type = Invnum.type(invoice_num) if invoice_num
    Severity: Minor
    Found in app/services/paypal_service/data_types/ipn.rb - About 1 hr to fix

      Method from_params has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def from_params(params)
        p = HashUtils.symbolize_keys(params)
        type = msg_type(p[:txn_type], p[:payment_status], p[:pending_reason], p[:invoice])

        case type
      Severity: Minor
      Found in app/services/paypal_service/data_types/ipn.rb - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                  return :payment_refunded
        Severity: Major
        Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return :commission_denied
          Severity: Major
          Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return :commission_pending_ext
            Severity: Major
            Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                        return :payment_completed
              Severity: Major
              Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                          return :unknown
                Severity: Major
                Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                            return :payment_pending_ext
                  Severity: Major
                  Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                              return :payment_voided
                    Severity: Major
                    Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                return :authorization_expired
                      Severity: Major
                      Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                  return :authorization_created
                        Severity: Major
                        Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                    return :payment_review
                          Severity: Major
                          Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                      return :commission_paid
                            Severity: Major
                            Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                        return :payment_denied
                              Severity: Major
                              Found in app/services/paypal_service/data_types/ipn.rb - About 30 mins to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                      def to_commission_paid(params)
        p = HashUtils.rename_keys(
          {
            invoice: :invnum,
            txn_id: :commission_payment_id,
                                Severity: Minor
                                Found in app/services/paypal_service/data_types/ipn.rb and 1 other location - About 40 mins to fix
                                app/services/paypal_service/data_types/ipn.rb on lines 454..469

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 37.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                      def to_commission_denied(params)
        p = HashUtils.rename_keys(
          {
            invoice: :invnum,
            txn_id: :commission_payment_id,
                                Severity: Minor
                                Found in app/services/paypal_service/data_types/ipn.rb and 1 other location - About 40 mins to fix
                                app/services/paypal_service/data_types/ipn.rb on lines 435..450

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 37.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                      CommissionPendingExt = EntityUtils.define_builder(
        [:type, const_value: :commission_pending_ext],
        [:commission_status, :string, :mandatory],
        [:commission_pending_reason, :string, :mandatory],
        [:commission_payment_id, :string, :mandatory],
                                Severity: Minor
                                Found in app/services/paypal_service/data_types/ipn.rb and 2 other locations - About 20 mins to fix
                                app/services/paypal_service/data_types/ipn.rb on lines 152..158
                                app/services/paypal_service/data_types/ipn.rb on lines 161..167

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 28.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                      CommissionPaid = EntityUtils.define_builder(
        [:type, const_value: :commission_paid],
        [:commission_status, :string, :mandatory],
        [:commission_payment_id, :string, :mandatory],
        [:commission_total, :money, :mandatory],
                                Severity: Minor
                                Found in app/services/paypal_service/data_types/ipn.rb and 2 other locations - About 20 mins to fix
                                app/services/paypal_service/data_types/ipn.rb on lines 161..167
                                app/services/paypal_service/data_types/ipn.rb on lines 170..176

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 28.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                      CommissionDenied = EntityUtils.define_builder(
        [:type, const_value: :commission_denied],
        [:commission_status, :string, :mandatory],
        [:commission_payment_id, :string, :mandatory],
        [:commission_total, :money, :mandatory],
                                Severity: Minor
                                Found in app/services/paypal_service/data_types/ipn.rb and 2 other locations - About 20 mins to fix
                                app/services/paypal_service/data_types/ipn.rb on lines 152..158
                                app/services/paypal_service/data_types/ipn.rb on lines 170..176

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 28.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status