Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
app/services/seo_service.rb

Summary

Maintainability
C
1 day
Test Coverage

Method eval_single has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

  def eval_single(variable, locale = I18n.locale)
    case variable
    when MARKETPLACE_NAME
      @community.name(locale)
    when MARKETPLACE_DESCRIPTION
Severity: Minor
Found in app/services/seo_service.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method mode_from_params has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def mode_from_params
    if @params.blank?
      'default'
    elsif @params[:action] == 'index' && @params[:controller] == 'homepage'
      if @params[:q].present? || @params[:lq].present?
Severity: Minor
Found in app/services/seo_service.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method eval_single has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def eval_single(variable, locale = I18n.locale)
    case variable
    when MARKETPLACE_NAME
      @community.name(locale)
    when MARKETPLACE_DESCRIPTION
Severity: Minor
Found in app/services/seo_service.rb - About 1 hr to fix

    Method placeholder has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def placeholder(section, locale = I18n.locale)
    case section
    when :homepage_title, :meta_title
      "{{#{MARKETPLACE_NAME}}} - {{#{MARKETPLACE_SLOGAN}}}"
    when :homepage_description, :meta_description
    Severity: Minor
    Found in app/services/seo_service.rb - About 1 hr to fix

      Method description has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def description(default_value, extra_mode = nil, locale = I18n.locale)
    @locale = locale
    custom_value =
      if mode == 'default' && extra_mode == :social
        # social media description is passed here from layout
      Severity: Minor
      Found in app/services/seo_service.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method title has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def title(default_value, extra_mode = nil, locale = I18n.locale)
    @locale = locale
    custom_value =
      if mode == 'default' && extra_mode == :social
        # social media title is passed here from layout
      Severity: Minor
      Found in app/services/seo_service.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def customization_title(mode, extra_mode = nil)
    case mode
    when 'homepage'
      if extra_mode == :social
        customization.social_media_title.presence || placeholder(:meta_title, locale)
      Severity: Minor
      Found in app/services/seo_service.rb and 1 other location - About 50 mins to fix
      app/services/seo_service.rb on lines 222..237

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def customization_description(mode, extra_mode = nil)
    case mode
    when 'homepage'
      if extra_mode == :social
        customization.social_media_description.presence || placeholder(:meta_description, locale)
      Severity: Minor
      Found in app/services/seo_service.rb and 1 other location - About 50 mins to fix
      app/services/seo_service.rb on lines 203..218

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def description(default_value, extra_mode = nil, locale = I18n.locale)
    @locale = locale
    custom_value =
      if mode == 'default' && extra_mode == :social
        # social media description is passed here from layout
      Severity: Minor
      Found in app/services/seo_service.rb and 1 other location - About 35 mins to fix
      app/services/seo_service.rb on lines 68..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def title(default_value, extra_mode = nil, locale = I18n.locale)
    @locale = locale
    custom_value =
      if mode == 'default' && extra_mode == :social
        # social media title is passed here from layout
      Severity: Minor
      Found in app/services/seo_service.rb and 1 other location - About 35 mins to fix
      app/services/seo_service.rb on lines 82..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def community_description(locale)
    customization = @community.community_customizations.where(locale: locale).first
    if customization&.description.present?
      customization.description
    elsif @community.description.present?
      Severity: Minor
      Found in app/services/seo_service.rb and 1 other location - About 15 mins to fix
      app/services/seo_service.rb on lines 181..189

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def community_slogan(locale)
    customization = @community.community_customizations.where(locale: locale).first
    if customization&.slogan.present?
      customization.slogan
    elsif @community.slogan.present?
      Severity: Minor
      Found in app/services/seo_service.rb and 1 other location - About 15 mins to fix
      app/services/seo_service.rb on lines 192..200

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status