Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
app/view_utils/intercom_helper.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method verify has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def verify(conversation_id)
    token = APP_CONFIG.admin_intercom_access_token
    admin_id = APP_CONFIG.admin_intercom_admin_id
    intercom = Intercom::Client.new(token: token)
Severity: Minor
Found in app/view_utils/intercom_helper.rb - About 1 hr to fix

    Method format_result_array has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def format_result_array(verification_result, icons)
    result =
      if verification_result[:result] == :passed
        "#{icons[:check]} Identity verification PASSED"
      elsif verification_result[:result] == :warning
    Severity: Minor
    Found in app/view_utils/intercom_helper.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method verify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def verify(conversation_id)
    token = APP_CONFIG.admin_intercom_access_token
    admin_id = APP_CONFIG.admin_intercom_admin_id
    intercom = Intercom::Client.new(token: token)
    Severity: Minor
    Found in app/view_utils/intercom_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status