Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
app/view_utils/transaction_view_utils.rb

Summary

Maintainability
C
1 day
Test Coverage

Method create_message_from_action has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create_message_from_action(transition, old_state, author, starter, payment_sum, payment_gateway, community, show_sum)
    preauthorize_accepted = ->(new_state) { new_state == "paid" && old_state == "preauthorized" }
    post_pay_accepted = ->(new_state) {
      # The condition here is simply "if new_state is paid", since due to migrations from old system there might be
      # transitions in "paid" state without previous state.
Severity: Major
Found in app/view_utils/transaction_view_utils.rb - About 2 hrs to fix

    Method create_content_from_action has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def create_content_from_action(state, old_state, payment_sum, payment_gateway, author, community, show_sum)
    preauthorize_accepted = ->(new_state) { new_state == "paid" && old_state == "preauthorized" }
    post_pay_accepted = ->(new_state) {
      # The condition here is simply "if new_state is paid", since due to migrations from old system there might be
      # transitions in "paid" state without previous state.
    Severity: Minor
    Found in app/view_utils/transaction_view_utils.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_content_from_action has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create_content_from_action(state, old_state, payment_sum, payment_gateway, author, community, show_sum)
    preauthorize_accepted = ->(new_state) { new_state == "paid" && old_state == "preauthorized" }
    post_pay_accepted = ->(new_state) {
      # The condition here is simply "if new_state is paid", since due to migrations from old system there might be
      # transitions in "paid" state without previous state.
    Severity: Major
    Found in app/view_utils/transaction_view_utils.rb - About 2 hrs to fix

      Method create_message_from_action has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def create_message_from_action(transition, old_state, author, starter, payment_sum, payment_gateway, community, show_sum)
      Severity: Major
      Found in app/view_utils/transaction_view_utils.rb - About 1 hr to fix

        Method create_content_from_action has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def create_content_from_action(state, old_state, payment_sum, payment_gateway, author, community, show_sum)
        Severity: Major
        Found in app/view_utils/transaction_view_utils.rb - About 50 mins to fix

          Method create_messages_from_actions has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def create_messages_from_actions(transitions, author, starter, payment_sum, payment_gateway, community, show_sum=true)
          Severity: Major
          Found in app/view_utils/transaction_view_utils.rb - About 50 mins to fix

            There are no issues that match your filters.

            Category
            Status