Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
lib/services/paypal_service/test_merchant.rb

Summary

Maintainability
D
1 day
Test Coverage

Method build_default_test_actions has 203 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def build_default_test_actions
      identity = -> (val, _) { val }

      {
        get_express_checkout_details: PaypalAction.def_action(
Severity: Major
Found in lib/services/paypal_service/test_merchant.rb - About 1 day to fix

    File test_merchant.rb has 332 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require_relative 'test_api'

module PaypalService

  module TestMerchant
    Severity: Minor
    Found in lib/services/paypal_service/test_merchant.rb - About 4 hrs to fix

      Method build_default_test_actions has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          def build_default_test_actions
      identity = -> (val, _) { val }

      {
        get_express_checkout_details: PaypalAction.def_action(
      Severity: Minor
      Found in lib/services/paypal_service/test_merchant.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status