Sign upLogin

shaungrady/angular-http-etag

View on GitHub
Star

Showing 91 of 91 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    function processCacheId (cacheId) {
      var type = typeof cacheId
      var isDefined = type === 'number' || (type === 'string' && !!cacheId)
      return isDefined ? cacheId : defaultCacheId
    }
Severity: Major
Found in lib/index.js and 2 other locations - About 55 mins to fix
release/angular-http-etag.js on lines 1477..1481
src/service.js on lines 223..227

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    function processCacheId (cacheId) {
      var type = typeof cacheId
      var isDefined = type === 'number' || (type === 'string' && !!cacheId)
      return isDefined ? cacheId : defaultCacheId
    }
Severity: Major
Found in release/angular-http-etag.js and 2 other locations - About 55 mins to fix
lib/index.js on lines 358..362
src/service.js on lines 223..227

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function httpEtagInterceptorFactory has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

function httpEtagInterceptorFactory () {
  function responseInterceptor (response) {
    var itemCache = response.config.$$_itemCache

    if (itemCache) {
Severity: Minor
Found in src/httpInterceptor.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    httpEtagService.purgeCaches = function httpEtagPurgeCaches () {
      external_angular_default.a.forEach(adaptedCaches, function (cache) {
        cache.removeAllItems()
      })
    }
Severity: Minor
Found in lib/index.js and 1 other location - About 45 mins to fix
release/angular-http-etag.js on lines 1471..1475

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    httpEtagService.purgeCaches = function httpEtagPurgeCaches () {
      external_angular_default.a.forEach(adaptedCaches, function (cache) {
        cache.removeAllItems()
      })
    }
Severity: Minor
Found in release/angular-http-etag.js and 1 other location - About 45 mins to fix
lib/index.js on lines 352..356

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Consider simplifying this complex logical expression.
Open

    if (!isArgs) {
        isArgs = str !== '[object Array]' &&
            value !== null &&
            typeof value === 'object' &&
            typeof value.length === 'number' &&
Severity: Major
Found in release/angular-http-etag.js - About 40 mins to fix

    Function recursiveCopy has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function recursiveCopy(value, clone, references, visited, customizer) {
    Severity: Minor
    Found in release/angular-http-etag.js - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (isArguments && object.length > 0) {
        for (var j = 0; j < object.length; ++j) {
            theKeys.push(String(j));
        }
    } else {
      Severity: Minor
      Found in release/angular-http-etag.js and 1 other location - About 35 mins to fix
      release/angular-http-etag.js on lines 615..619

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (isString && object.length > 0 && !has.call(object, 0)) {
        for (var i = 0; i < object.length; ++i) {
            theKeys.push(String(i));
        }
    }
      Severity: Minor
      Found in release/angular-http-etag.js and 1 other location - About 35 mins to fix
      release/angular-http-etag.js on lines 621..631

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

            return 'Document';
      Severity: Major
      Found in release/angular-http-etag.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return 'PluginArray';
        Severity: Major
        Found in release/angular-http-etag.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return 'Object';
          Severity: Major
          Found in release/angular-http-etag.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return 'HTMLQuoteElement';
            Severity: Major
            Found in release/angular-http-etag.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return stringTag;
              Severity: Major
              Found in release/angular-http-etag.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return 'HTMLTableDataCellElement';
                Severity: Major
                Found in release/angular-http-etag.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return 'Set';
                  Severity: Major
                  Found in release/angular-http-etag.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return 'WeakSet';
                    Severity: Major
                    Found in release/angular-http-etag.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return 'HTMLTableHeaderCellElement';
                      Severity: Major
                      Found in release/angular-http-etag.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return 'Promise';
                        Severity: Major
                        Found in release/angular-http-etag.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return 'WeakMap';
                          Severity: Major
                          Found in release/angular-http-etag.js - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language