Sign upLogin

shawn42/gamebox

View on GitHub
Star
examples/pending/netris/src/grid.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class Grid has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

class Grid
  extend Publisher

  can_fire :game_over, :next_level
Severity: Minor
Found in examples/pending/netris/src/grid.rb - About 2 hrs to fix

    Method check_row_removal has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_row_removal
    to_remove = []
    # First, we find all rows that need removing
    @field.each_with_index do |row, idx|
      # Ignore last row
    Severity: Minor
    Found in examples/pending/netris/src/grid.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_row_removal has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check_row_removal
    to_remove = []
    # First, we find all rows that need removing
    @field.each_with_index do |row, idx|
      # Ignore last row
    Severity: Minor
    Found in examples/pending/netris/src/grid.rb - About 1 hr to fix

      Method collides? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def collides?
    hit = false
    current_rotated_blocks.each do |block|
      row = @falling_piece.grid_position.y + block[1]
      col = @falling_piece.grid_position.x + block[0]
      Severity: Minor
      Found in examples/pending/netris/src/grid.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status