Sign upLogin

shawn42/gamebox

View on GitHub
Star
lib/gamebox/lib/rect.rb

Summary

Maintainability
D
2 days
Test Coverage

Class Rect has 67 methods (exceeds 20 allowed). Consider refactoring.
Open

class Rect < Array
  include MinMaxHelpers

  #--
  # GENERAL
Severity: Major
Found in lib/gamebox/lib/rect.rb - About 1 day to fix

    File rect.rb has 356 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Rect < Array
  include MinMaxHelpers

  #--
  # GENERAL
    Severity: Minor
    Found in lib/gamebox/lib/rect.rb - About 4 hrs to fix

      Method new_from_object has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def Rect.new_from_object(object)
    case(object)
    when Rect
      return object.dup
    when Array
      Severity: Minor
      Found in lib/gamebox/lib/rect.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method clamp! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def clamp!(rect)
    nself = self.normalize
    rect = Rect.new_from_object(rect)
    #If self is inside given, there is no need to move self
    unless rect.contain?(nself)
      Severity: Minor
      Found in lib/gamebox/lib/rect.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if nself[2] >= rect[2]
        self[0] = rect.centerx - nself[2].div(2)
        #Else self is not too wide
      else
        #If self is to the left of arg
      Severity: Major
      Found in lib/gamebox/lib/rect.rb and 1 other location - About 1 hr to fix
      lib/gamebox/lib/rect.rb on lines 400..411

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if nself[3] >= rect[3]
        self[1] = rect.centery - nself[3].div(2)
        #Else self is not too tall
      else
        #If self is above arg
      Severity: Major
      Found in lib/gamebox/lib/rect.rb and 1 other location - About 1 hr to fix
      lib/gamebox/lib/rect.rb on lines 385..396

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if self[3] < 0
      self[1], self[3] = self[1]+self[3], -self[3]
      Severity: Minor
      Found in lib/gamebox/lib/rect.rb and 1 other location - About 15 mins to fix
      lib/gamebox/lib/rect.rb on lines 556..557

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if self[2] < 0
      self[0], self[2] = self[0]+self[2], -self[2]
      Severity: Minor
      Found in lib/gamebox/lib/rect.rb and 1 other location - About 15 mins to fix
      lib/gamebox/lib/rect.rb on lines 559..560

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status