Sign upLogin

shideneyu/ownlan

View on GitHub
Star

Showing 4 of 4 total issues

Method options has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.options
      Trollop::options do

        version "OwnLan (c) 2016 Sidney Sissaoui, published under the MIT Licence"
        banner <<-EOS
Severity: Minor
Found in lib/ownlan/cli.rb - About 1 hr to fix

    Method process has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

          def process
        @a = 10
        @b = 10
        @c = 10
        @i = 0
    Severity: Minor
    Found in lib/ownlan/attack/ntoa.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def process
        @a = 10
        @b = 10
        @c = 10
        @i = 0
    Severity: Minor
    Found in lib/ownlan/attack/ntoa.rb - About 1 hr to fix

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def initialize(saddr, daddr, saddr_ip, daddr_ip, opcode = 2)
      Severity: Minor
      Found in lib/ownlan/service_objects/craft_arp_packets.rb - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language