Sign upLogin

shieldfy/normalizer

View on GitHub
Star
src/Normalizers/NormalizeSerialize.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method run has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        if (! $this->runPreSearch()) {
            return $this->value;
        }
Severity: Minor
Found in src/Normalizers/NormalizeSerialize.php - About 1 hr to fix

    Function run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function run()
    {
        if (! $this->runPreSearch()) {
            return $this->value;
        }
    Severity: Minor
    Found in src/Normalizers/NormalizeSerialize.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $decoded;
    Severity: Major
    Found in src/Normalizers/NormalizeSerialize.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $this->value;
      Severity: Major
      Found in src/Normalizers/NormalizeSerialize.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $this->value;
        Severity: Major
        Found in src/Normalizers/NormalizeSerialize.php - About 30 mins to fix

          The method run() has an NPath complexity of 256. The configured NPath complexity threshold is 200.
          Open

              public function run()
    {
        if (! $this->runPreSearch()) {
            return $this->value;
        }
          Severity: Minor
          Found in src/Normalizers/NormalizeSerialize.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
    function bar() {
        // lots of complicated code
    }
}

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          Remove error control operator '@' on line 65.
          Open

              public function run()
    {
        if (! $this->runPreSearch()) {
            return $this->value;
        }
          Severity: Minor
          Found in src/Normalizers/NormalizeSerialize.php by phpmd

          ErrorControlOperator

          Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

          Example

          function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

          Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

          There are no issues that match your filters.

          Category
          Status