shieldfy/waf-detector

View on GitHub

Showing 10 of 10 total issues

Remove error control operator '@' on line 46.
Open

    public function detect(array $headers, $bodyString, $url)
    {
        $response = @file_get_contents("{$url}/../../etc");

        if (strstr($response['content'], 'Mod_Security')) {
Severity: Minor
Found in src/Firewall/ModSecurity.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Avoid unused parameters such as '$bodyString'.
Open

    public function detect(array $headers, $bodyString, $url)
Severity: Minor
Found in src/Firewall/Incapsula.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$headers'.
Open

    public function detect(array $headers, $bodyString, $url)
Severity: Minor
Found in src/Firewall/ModSecurity.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$bodyString'.
Open

    public function detect(array $headers, $bodyString, $url)
Severity: Minor
Found in src/Firewall/Shieldfy.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$url'.
Open

    public function detect(array $headers, $bodyString, $url)
Severity: Minor
Found in src/Firewall/Incapsula.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$url'.
Open

    public function detect(array $headers, $bodyString, $url)
Severity: Minor
Found in src/Firewall/Shieldfy.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid assigning values to variables in if clauses and the like (line '90', column '24').
Open

    protected function fetch($url)
    {
        $resource = curl_init($url);
        curl_setopt_array($resource, $this->cUrlOptions);
        $response = curl_exec($resource);
Severity: Minor
Found in src/Detector.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid unused parameters such as '$bodyString'.
Open

    public function detect(array $headers, $bodyString, $url)
Severity: Minor
Found in src/Firewall/CloudFlare.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$url'.
Open

    public function detect(array $headers, $bodyString, $url)
Severity: Minor
Found in src/Firewall/CloudFlare.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$bodyString'.
Open

    public function detect(array $headers, $bodyString, $url)
Severity: Minor
Found in src/Firewall/ModSecurity.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Severity
Category
Status
Source
Language