Sign upLogin

shikhalev/drctrl

View on GitHub
Star

Showing 3 of 3 total issues

Method detect has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def detect name, pid = nil
      if pid
        result = "/tmp/#{name}-#{pid}"
        if File.socket? result
          return result
Severity: Minor
Found in lib/drctrl/client.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return result
Severity: Major
Found in lib/drctrl/client.rb - About 30 mins to fix

    Method connect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def connect uri: nil, path: nil, name: nil, pid: nil
      if uri
        DRbObject.new nil, uri
      elsif path
        DRbObject.new nil, "drbunix:#{path}"
    Severity: Minor
    Found in lib/drctrl/client.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language