Sign upLogin

shimabox/SMBArrayto

View on GitHub
Star

Showing 5 of 5 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
 
namespace SMB\Arrayto\Plugins\Tsv;
 
use SMB\Arrayto\Interfaces\Downloadable;
Severity: Major
Found in src/SMB/Arrayto/Plugins/Tsv/Downloader.php and 1 other location - About 6 hrs to fix
src/SMB/Arrayto/Plugins/Csv/Downloader.php on lines 1..63

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
 
namespace SMB\Arrayto\Plugins\Csv;
 
use SMB\Arrayto\Interfaces\Downloadable;
Severity: Major
Found in src/SMB/Arrayto/Plugins/Csv/Downloader.php and 1 other location - About 6 hrs to fix
src/SMB/Arrayto/Plugins/Tsv/Downloader.php on lines 1..63

Function _convertElement has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    private function _convertElement(DOMElement $element, $value)
    {
        $sequential = $this->isArrayAllKeySequential($value);
 
        if (!is_array($value)) {
Severity: Minor
Found in src/SMB/Arrayto/Formatter/ArrayToXml.php - About 1 hr to fix

Method forge has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        array $array,
        $rootElementName = '',
        $replaceSpacesByUnderScoresInKeyNames = true,
        $version = '1.0',
        $encoding = 'UTF-8'
Severity: Minor
Found in src/SMB/Arrayto/Formatter/ArrayToXml.php - About 35 mins to fix

    Avoid too many return statements within this method.
    Open

                    return Arrayto\Xml::factory();
    Severity: Major
    Found in src/SMB/Arrayto.php - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language