Sign upLogin

shimabox/SMBArrayto

View on GitHub
Star

Showing 3 of 5 total issues

Function _convertElement has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    private function _convertElement(DOMElement $element, $value)
    {
        $sequential = $this->isArrayAllKeySequential($value);

        if (!is_array($value)) {
Severity: Minor
Found in src/SMB/Arrayto/Formatter/ArrayToXml.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method forge has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        array $array,
        $rootElementName = '',
        $replaceSpacesByUnderScoresInKeyNames = true,
        $version = '1.0',
        $encoding = 'UTF-8'
Severity: Minor
Found in src/SMB/Arrayto/Formatter/ArrayToXml.php - About 35 mins to fix

    Avoid too many return statements within this method.
    Open

                    return Arrayto\Xml::factory();
    Severity: Major
    Found in src/SMB/Arrayto.php - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language