shimabox/pemojine

View on GitHub
scraping/src/Parser/Parser.php

Summary

Maintainability
F
3 days
Test Coverage

Function fetchTableRows has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    private function fetchTableRows($url)
    {
        $dom = PHPQuery::newDocumentFile($url);

        $tableRows = pq($dom)->find('.main table')->eq(0)->find('tr');
Severity: Minor
Found in scraping/src/Parser/Parser.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    public function parse($url, $cacheFileName, $cacheExpires = 60 * 60)
    {
        $cacheFile = $this->cacheDir . '/' . $cacheFileName;

        if (
Severity: Minor
Found in scraping/src/Parser/Parser.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function parse($url, $cacheFileName, $cacheExpires = 60 * 60)
    {
        $cacheFile = $this->cacheDir . '/' . $cacheFileName;

        if (
Severity: Major
Found in scraping/src/Parser/Parser.php - About 3 hrs to fix

    Function merge has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        public function merge(BigGroups $base, BigGroups $add)
        {
            foreach ($base->getBigGroups() as $bigGroupName => $bigGroup) {
    
                foreach ($bigGroup->getMediumGroups() as $mediumGroupName => $mediumGroup) {
    Severity: Minor
    Found in scraping/src/Parser/Parser.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method fetchTableRows has 93 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function fetchTableRows($url)
        {
            $dom = PHPQuery::newDocumentFile($url);
    
            $tableRows = pq($dom)->find('.main table')->eq(0)->find('tr');
    Severity: Major
    Found in scraping/src/Parser/Parser.php - About 3 hrs to fix

      File Parser.php has 269 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      namespace SMB\Pemojine\Scraping\Parser;
      
      use SMB\Pemojine\Scraping\Emoji\BigGroups;
      Severity: Minor
      Found in scraping/src/Parser/Parser.php - About 2 hrs to fix

        Method fetchShortNamesFromJoyPixelsJson has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function fetchShortNamesFromJoyPixelsJson()
            {
                static $shortNames;
        
                if ($shortNames !== null) {
        Severity: Minor
        Found in scraping/src/Parser/Parser.php - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status