shimabox/screru

View on GitHub
src/Screenshot/Screenshot.php

Summary

Maintainability
D
1 day
Test Coverage
B
85%

Method takeFull has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function takeFull(RemoteWebDriver $driver, $filepath, $filename, $sleep=1)
    {
        (int)$sleep <= 0 ?: sleep((int)$sleep);

        $_filename = $this->removeExtension($filename);
Severity: Major
Found in src/Screenshot/Screenshot.php - About 2 hrs to fix

    Function takeFull has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function takeFull(RemoteWebDriver $driver, $filepath, $filename, $sleep=1)
        {
            (int)$sleep <= 0 ?: sleep((int)$sleep);
    
            $_filename = $this->removeExtension($filename);
    Severity: Minor
    Found in src/Screenshot/Screenshot.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method takeElement has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function takeElement(RemoteWebDriver $driver, $filepath, $filename, SpecPool $specPool, $sleep=1)
        {
            // 一旦全画面のキャプチャを撮る
            $_filename = $this->removeExtension($filename);
            $tmpFullScreenshot = $this->takeFull($driver, $filepath, $_filename . '_tmp_' . microtime(true) . '.png', $sleep);
    Severity: Minor
    Found in src/Screenshot/Screenshot.php - About 1 hr to fix

      Method toPatchTheImage has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private function toPatchTheImage($captureFile, $dest, $src, $destX, $destY, $srcX, $srcY, $srcW, $srcH)
      Severity: Major
      Found in src/Screenshot/Screenshot.php - About 1 hr to fix

        Method notify has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function notify(
                RemoteWebDriver $driver, 
                $contentsWidth, 
                $contentsHeight, 
                $scrollWidth, 
        Severity: Minor
        Found in src/Screenshot/Screenshot.php - About 1 hr to fix

          Method notify has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  RemoteWebDriver $driver, 
                  $contentsWidth, 
                  $contentsHeight, 
                  $scrollWidth, 
                  $scrollHeight, 
          Severity: Major
          Found in src/Screenshot/Screenshot.php - About 1 hr to fix

            Function notify has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                private function notify(
                    RemoteWebDriver $driver, 
                    $contentsWidth, 
                    $contentsHeight, 
                    $scrollWidth, 
            Severity: Minor
            Found in src/Screenshot/Screenshot.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method takeElement has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function takeElement(RemoteWebDriver $driver, $filepath, $filename, SpecPool $specPool, $sleep=1)
            Severity: Minor
            Found in src/Screenshot/Screenshot.php - About 35 mins to fix

              Avoid too many return statements within this method.
              Open

                          return;
              Severity: Major
              Found in src/Screenshot/Screenshot.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return $captureFileList;
                Severity: Major
                Found in src/Screenshot/Screenshot.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return;
                  Severity: Major
                  Found in src/Screenshot/Screenshot.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                                return $count >= $expected;
                    Severity: Major
                    Found in src/Screenshot/Screenshot.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                                  return $count <= $expected;
                      Severity: Major
                      Found in src/Screenshot/Screenshot.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return;
                        Severity: Major
                        Found in src/Screenshot/Screenshot.php - About 30 mins to fix

                          There are no issues that match your filters.

                          Category
                          Status