Sign upLogin

shiwaforce/poco

View on GitHub
Star
poco/commands/project_add.py

Summary

Maintainability
A
35 mins
Test Coverage
B
86%

Function get_normalized_dir has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def get_normalized_dir(self):
        target_dir = StateHolder.args.get('<target-dir>')
        if target_dir is not None:
            if not os.path.exists(target_dir):
                if os.path.exists(os.path.join(os.getcwd(), target_dir)):
Severity: Minor
Found in poco/commands/project_add.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Merge this if statement with the enclosing one.
Open

                if os.path.exists(os.path.join(os.getcwd(), target_dir)):
Severity: Major
Found in poco/commands/project_add.py by sonar-python

Merging collapsible if statements increases the code's readability.

Noncompliant Code Example

if condition1:
    if condition2:
        # ...

Compliant Solution

if condition1 and condition2:
    # ...

There are no issues that match your filters.

Category
Status