Showing 47 of 47 total issues

include is used at the top level. Use inside class or module.
Open

include GLI::App
Severity: Minor
Found in bin/frecli by rubocop

This cop checks that include, extend and prepend exists at the top level. Using these at the top level affects the behavior of Object. There will not be using include, extend and prepend at the top level. Let's use it inside class or module.

Example:

# bad
include M

class C
end

# bad
extend M

class C
end

# bad
prepend M

class C
end

# good
class C
  include M
end

# good
class C
  extend M
end

# good
class C
  prepend M
end

Space missing after comma.
Open

  rd.rdoc_files.include("README.rdoc","lib/**/*.rb","bin/**/*")
Severity: Minor
Found in Rakefile by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Space missing after comma.
Open

post do |global,command,options,args|
Severity: Minor
Found in bin/frecli by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Prefer JSON.parse over JSON.load.
Open

        collection = JSON.load(file)
Severity: Minor
Found in lib/frecli/cache.rb by rubocop

This cop checks for the use of JSON class methods which have potential security issues.

Autocorrect is disabled by default because it's potentially dangerous. If using a stream, like JSON.load(open('file')), it will need to call #read manually, like JSON.parse(open('file').read). If reading single values (rather than proper JSON objects), like JSON.load('false'), it will need to pass the quirks_mode: true option, like JSON.parse('false', quirks_mode: true). Other similar issues may apply.

Example:

# always offense
JSON.load("{}")
JSON.restore("{}")

# no offense
JSON.parse("{}")

Unused block argument - options. You can omit all the arguments if you don't care about them.
Open

pre do |global,command,options,args|
Severity: Minor
Found in bin/frecli by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

TODO found
Open

## TODO
Severity: Minor
Found in README.md by fixme

TODO found
Open

# TODO: consider how to include this locally for convenience.
Severity: Minor
Found in Gemfile by fixme
Severity
Category
Status
Source
Language