shootismoke/webapp

View on GitHub
src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx

Summary

Maintainability
D
2 days
Test Coverage

Avoid too many return statements within this function.
Open

        return [
            <HealthTip imgAlt="warning" imgSrc={warning} key={1}>
                <p className="type-400 md:type-500">
                    <span className="text-orange">Health alert:</span> Stop
                    outdoor activities and move all activities indoors.
Severity: Major
Found in src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return [
                <HealthTip imgAlt="warning" imgSrc={warning} key={1}>
                    <p className="type-400 md:type-500">
                        <span className="text-orange">Health alert:</span> everyone
                        may experience more serious health effects.
    Severity: Major
    Found in src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx - About 30 mins to fix

      Function tips has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function tips(aqi: number): React.ReactElement[] {
          if (aqi <= 50) {
              return [
                  <HealthTip imgAlt="happy" imgSrc={happy} key={1}>
                      <p className="type-400 md:type-500">
      Severity: Minor
      Found in src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          } else if (aqi <= 150) {
              return [
                  <HealthTip imgAlt="cry" imgSrc={cry} key={1}>
                      <p className="type-400 md:type-500">
                          Experiencing discomfort such as sore eyes, cough or sore
      src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx on lines 107..159

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 150.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          } else if (aqi <= 200) {
              return [
                  <HealthTip imgAlt="cry" imgSrc={cry} key={1}>
                      <p className="type-400 md:type-500">
                          Everyone experiencing discomfort such as sore eyes, cough or
      src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx on lines 87..159

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 150.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  <HealthTip imgAlt="warning" imgSrc={warning} key={2}>
                      <p className="type-400 md:type-500">
                          For some pollutants there may be a{' '}
                          <span className="text-orange">moderate health concern</span>{' '}
                          for a very small number of people who are unusually
      src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx on lines 134..142

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  <HealthTip imgAlt="house" imgSrc={house} key={2}>
                      <p className="type-400 md:type-500">
                          Everyone should{' '}
                          <span className="text-orange">
                              reduce outdoor activities,
      src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx on lines 78..85

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  <HealthTip imgAlt="warning" imgSrc={warning} key={1}>
                      <p className="type-400 md:type-500">
                          <span className="text-orange">Health alert:</span> everyone
                          may experience more serious health effects.
                      </p>
      src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx on lines 62..67
      src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx on lines 146..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  <HealthTip imgAlt="fitness" imgSrc={fitness} key={2}>
                      <p className="type-400 md:type-500">
                          <span className="text-orange">Enjoy</span> your usual
                          outdoor activities.
                      </p>
      src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx on lines 128..133
      src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx on lines 146..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  <HealthTip imgAlt="warning" imgSrc={warning} key={1}>
                      <p className="type-400 md:type-500">
                          <span className="text-orange">Health alert:</span> Stop
                          outdoor activities and move all activities indoors.
                      </p>
      src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx on lines 62..67
      src/frontend/components/PollutantSection/HealthSection/HealthSection.tsx on lines 128..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status