Sign upLogin

shopinvader/locomotive-shopinvader

View on GitHub
Star

Showing 25 of 25 total issues

Method parse_response has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def parse_response(response)
      headers = response.headers
      if headers['content-type'] == 'application/json'
        res = JSON.parse(response.body)
        if res.include?('set_session')
Severity: Minor
Found in lib/shop_invader/services/erp_service.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_params has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def build_params(conditions)
      { numericFilters: [], facetFilters: [] }.tap do |params|
        conditions.each do |key, value|
          name, op = key.split('.')
          build_attr(name, value).each do | name, value |
Severity: Minor
Found in lib/shop_invader/services/algolia_service.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _call has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

      def _call
        if env['steam.path'].start_with?('invader/')
          path = env['steam.path'].sub('invader/', '')
          if recaptcha_required(path) && !is_recaptcha_verified?(params.delete("g-recaptcha-response"))
            if force_redirection || html_form_edition
Severity: Minor
Found in lib/shop_invader/middlewares/erp_proxy.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_response has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def parse_response(response)
      headers = response.headers
      if headers['content-type'] == 'application/json'
        res = JSON.parse(response.body)
        if res.include?('set_session')
Severity: Minor
Found in lib/shop_invader/services/erp_service.rb - About 1 hr to fix

    Method find_all_products_and_categories has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def find_all_products_and_categories
      indices.map do |config|
        {}.tap do |records|
          site.locales.each do |locale|
            index = build_index_name(config['index'], locale.to_s)
    Severity: Minor
    Found in lib/shop_invader/services/elastic_service.rb - About 1 hr to fix

      Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(source, page, per_page)
      if source.respond_to?(:paginate, true)
        @current_page, @per_page = page || 1, per_page || DEFAULT_PER_PAGE

        collection = source.send(:paginate, @current_page, @per_page)
      Severity: Minor
      Found in lib/shop_invader/steam_patches.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method subscribe_to_steam_notifications has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.subscribe_to_steam_notifications

    # new signups
    ActiveSupport::Notifications.subscribe('steam.auth.signed_up') do |name, start, finish, id, payload|
      service = Locomotive::Steam::Services.build_instance(payload[:request])
      Severity: Minor
      Found in lib/shop_invader.rb - About 1 hr to fix

        Method initialize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                  def initialize(tag_name, markup, options)
            syntax_error = false
            if markup =~ SyntaxAsWith
              @method_name, service_path, @to = $1, $2, $3
              parse_attributes($4)
        Severity: Minor
        Found in lib/shop_invader/liquid/tags/erp.rb - About 1 hr to fix

          Method _find_by_key has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def _find_by_key(name, key)
      body = {
        query:{
          bool:{
              should: [
          Severity: Minor
          Found in lib/shop_invader/services/elastic_service.rb - About 1 hr to fix

            Method find_all_products_and_categories has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def find_all_products_and_categories
      indices.map do |config|
        {}.tap do |records|
          site.locales.each do |locale|
            index   = Algolia::Index.new(build_index_name(config['index'], locale.to_s), @client)
            Severity: Minor
            Found in lib/shop_invader/services/algolia_service.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method build_params has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def build_params(conditions)
      { bool: { filter: [], must_not: [] }}.tap do |params|
        if conditions.key?('raw_es_query')
            return conditions['raw_es_query']
        end
            Severity: Minor
            Found in lib/shop_invader/services/elastic_service.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method _call has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                  def _call
        if env['steam.page'].not_found? && resource = find_resource
          if redirect_to_main_variant?(resource)
            same_locale = locale == default_locale
            if site.prefix_default_locale || !same_locale
            Severity: Minor
            Found in lib/shop_invader/middlewares/templatized_page.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method initialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                      def initialize(tag_name, markup, options)
            syntax_error = false
            if markup =~ SyntaxAsWith
              @method_name, service_path, @to = $1, $2, $3
              parse_attributes($4)
            Severity: Minor
            Found in lib/shop_invader/liquid/tags/erp.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def initialize(request, site, session, customer, locale, cookie_service, entry_service)
            Severity: Major
            Found in lib/shop_invader/services/erp_service.rb - About 50 mins to fix

              Method find_all_products_and_categories has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def find_all_products_and_categories
      indices.map do |config|
        {}.tap do |records|
          site.locales.each do |locale|
            index = build_index_name(config['index'], locale.to_s)
              Severity: Minor
              Found in lib/shop_invader/services/elastic_service.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method liquid_method_missing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                      def liquid_method_missing(meth)
          if ONLY_SESSION_STORE.include?(meth)
            data = service.erp.is_cached?(meth) && service.erp.read_from_cache(meth)
            if ONLY_ONE_TIME.include?(meth)
              service.erp.clear_cache(meth)
              Severity: Minor
              Found in lib/shop_invader/liquid/drops/store.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method subscribe_to_steam_notifications has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.subscribe_to_steam_notifications

    # new signups
    ActiveSupport::Notifications.subscribe('steam.auth.signed_up') do |name, start, finish, id, payload|
      service = Locomotive::Steam::Services.build_instance(payload[:request])
              Severity: Minor
              Found in lib/shop_invader.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          result['hits']['hits'].each do |hit|
              record = records[hit['_id']] ||= {}
              record[locale] = { name: hit['_source']['name'], url: find_route(config['name']).gsub('*', hit['_source']['url_key']) }
              Severity: Minor
              Found in lib/shop_invader/services/elastic_service.rb and 1 other location - About 45 mins to fix
              lib/shop_invader/services/elastic_service.rb on lines 59..61

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 39.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                            result['hits']['hits'].each do |hit|
                record = records[hit['_id']] ||= {}
                record[locale] = { name: hit['_source']['name'], url: find_route(config['name']).gsub('*', hit['_source']['url_key']) }
              Severity: Minor
              Found in lib/shop_invader/services/elastic_service.rb and 1 other location - About 45 mins to fix
              lib/shop_invader/services/elastic_service.rb on lines 51..53

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 39.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method set_200_header has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                      def set_200_header(headers)
          headers['Cache-Control'] = env['steam.cache_control'] || "max-age=0, private, must-revalidate"

          # Always inject a vary on accept-language for the header
          # if the site have multiple lang on the home page
              Severity: Minor
              Found in lib/shop_invader/middlewares/helpers.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language