Sign upLogin

shopinvader/odoo-shopinvader-payment

View on GitHub
Star
shopinvader_quotation_payment/services/invader_payment_service.py

Summary

Maintainability
A
25 mins
Test Coverage

Function _invader_find_payable_from_target has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _invader_find_payable_from_target(self, target, **params):
        if target == "quotation":
            quotation_id = params.get("quotation_id")
            if not quotation_id:
                raise UserError(_("Quotation id is missing"))
Severity: Minor
Found in shopinvader_quotation_payment/services/invader_payment_service.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status