Sign upLogin

shopinvader/odoo-shopinvader

View on GitHub
Star
shopinvader_product_stock/models/product_product.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function _synchronize_all_binding_stock_level has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    def _synchronize_all_binding_stock_level(self):
        """
        The goal of this function is to compute the new stock information
        and update them in the data field. If data have change and the binding
        is in done state we force it to 'to_update'.
Severity: Minor
Found in shopinvader_product_stock/models/product_product.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if binding.sync_state == "done":
                            vals["sync_state"] = "to_update"
                        binding.write(vals)
Severity: Major
Found in shopinvader_product_stock/models/product_product.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status