short-d/short

View on GitHub

Showing 126 of 307 total issues

Function NewShort has 99 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func NewShort(
    instrumentationFactory request.InstrumentationFactory,
    webFrontendURL string,
    timer timer.Timer,
    shortLinkRetriever shortlink.Retriever,
Severity: Major
Found in backend/app/adapter/routing/route.go - About 2 hrs to fix

    Function main has 98 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func main() {
        env := dep.InjectEnv()
        env.AutoLoadDotEnvFile()
    
        envConfig := envconfig.NewEnvConfig(env)
    Severity: Major
    Found in backend/main.go - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        test('should render with correct placeholder', () => {
          const { container } = render(<TextAreaField placeholder={'placeholder'} />);
          const textarea = container.querySelector('textarea');
      
          expect(textarea).toBeTruthy();
      Severity: Major
      Found in frontend/src/component/form/TextAreaField.spec.tsx and 1 other location - About 2 hrs to fix
      frontend/src/component/form/TextAreaField.spec.tsx on lines 10..16

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        test('should render with correct value', () => {
          const { container } = render(<TextAreaField value={'text'} />);
          const textarea = container.querySelector('textarea');
      
          expect(textarea).toBeTruthy();
      Severity: Major
      Found in frontend/src/component/form/TextAreaField.spec.tsx and 1 other location - About 2 hrs to fix
      frontend/src/component/form/TextAreaField.spec.tsx on lines 18..24

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function InjectRoutingService has 23 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func InjectRoutingService(runtime2 env.Runtime, prefix provider.LogPrefix, logLevel logger.LogLevel, sqlDB *sql.DB, githubClientID provider.GithubClientID, githubClientSecret provider.GithubClientSecret, facebookClientID provider.FacebookClientID, facebookClientSecret provider.FacebookClientSecret, facebookRedirectURI provider.FacebookRedirectURI, googleClientID provider.GoogleClientID, googleClientSecret provider.GoogleClientSecret, googleRedirectURI provider.GoogleRedirectURI, jwtSecret provider.JwtSecret, bufferSize provider.KeyGenBufferSize, kgsRPCConfig provider.KgsRPCConfig, webFrontendURL provider.WebFrontendURL, tokenValidDuration provider.TokenValidDuration, searchTimeout provider.SearchTimeout, swaggerUIDir provider.SwaggerUIDir, openAPISpecPath provider.OpenAPISpecPath, dataDogAPIKey provider.DataDogAPIKey, segmentAPIKey provider.SegmentAPIKey, ipStackAPIKey provider.IPStackAPIKey) (service.Routing, error) {
      Severity: Major
      Found in backend/dep/wire_gen.go - About 2 hrs to fix

        Function InjectRoutingService has 23 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            runtime env.Runtime,
            prefix provider.LogPrefix,
            logLevel logger.LogLevel,
            sqlDB *sql.DB,
            githubClientID provider.GithubClientID,
        Severity: Major
        Found in backend/dep/wire.go - About 2 hrs to fix

          Function initUIFactory has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function initUIFactory(
            envService: EnvService,
            captchaService: CaptchaService
          ): UIFactory {
            const cookieService = new CookieService();
          Severity: Major
          Found in frontend/src/dep.ts - About 2 hrs to fix

            Function InjectGraphQLService has 16 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                runtime env.Runtime,
                prefix provider.LogPrefix,
                logLevel logger.LogLevel,
                sqlDB *sql.DB,
                graphqlSchemaPath provider.GraphQLSchemaPath,
            Severity: Major
            Found in backend/dep/wire.go - About 2 hrs to fix

              Function InjectGraphQLService has 16 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func InjectGraphQLService(runtime2 env.Runtime, prefix provider.LogPrefix, logLevel logger.LogLevel, sqlDB *sql.DB, graphqlSchemaPath provider.GraphQLSchemaPath, graphqlPath provider.GraphQLPath, graphiQLDefaultQuery provider.GraphiQLDefaultQuery, secret provider.ReCaptchaSecret, jwtSecret provider.JwtSecret, bufferSize provider.KeyGenBufferSize, kgsRPCConfig provider.KgsRPCConfig, tokenValidDuration provider.TokenValidDuration, dataDogAPIKey provider.DataDogAPIKey, segmentAPIKey provider.SegmentAPIKey, ipStackAPIKey provider.IPStackAPIKey, googleAPIKey provider.GoogleAPIKey) (service.GraphQL, error) {
              Severity: Major
              Found in backend/dep/wire_gen.go - About 2 hrs to fix

                Function NewShortRoutes has 12 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    instrumentationFactory request.InstrumentationFactory,
                    webFrontendURL WebFrontendURL,
                    timer timer.Timer,
                    shortLinkRetriever shortlink.Retriever,
                    featureDecisionMakerFactory feature.DecisionMakerFactory,
                Severity: Major
                Found in backend/dep/provider/routes.go - About 1 hr to fix

                  Function NewShort has 12 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      instrumentationFactory request.InstrumentationFactory,
                      webFrontendURL string,
                      timer timer.Timer,
                      shortLinkRetriever shortlink.Retriever,
                      featureDecisionMakerFactory feature.DecisionMakerFactory,
                  Severity: Major
                  Found in backend/app/adapter/routing/route.go - About 1 hr to fix

                    Function registerValidSW has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function registerValidSW(swUrl, config) {
                        navigator.serviceWorker
                            .register(swUrl)
                            .then(registration => {
                                registration.onupdatefound = () => {
                    Severity: Minor
                    Found in frontend/src/serviceWorker.js - About 1 hr to fix

                      Method SingleSignOn.SignIn has 7 return statements (exceeds 4 allowed).
                      Open

                      func (o SingleSignOn) SignIn(authorizationCode string) (string, error) {
                          if len(authorizationCode) < 1 {
                              return "", errors.New("authorizationCode can't be empty")
                          }
                      
                      
                      Severity: Major
                      Found in backend/app/usecase/sso/sso.go - About 45 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        interface IProps {
                          text?: string;
                          placeHolder?: string;
                          onChange?: (text: string) => void;
                          onBlur?: () => void;
                        Severity: Minor
                        Found in frontend/src/component/form/TextField.tsx and 1 other location - About 40 mins to fix
                        frontend/src/component/form/TextAreaField.tsx on lines 4..9

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 49.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        interface IProps {
                          value?: string;
                          placeholder?: string;
                          onChange?: (value: string) => void;
                          onBlur?: () => void;
                        Severity: Minor
                        Found in frontend/src/component/form/TextAreaField.tsx and 1 other location - About 40 mins to fix
                        frontend/src/component/form/TextField.tsx on lines 4..9

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 49.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                  <div className={'close-icon'}>
                                    <Icon iconID={IconID.Close} onClick={this.handleCloseClick} />
                                  </div>
                        Severity: Minor
                        Found in frontend/src/component/pages/shared/ErrorModal.tsx and 1 other location - About 40 mins to fix
                        frontend/src/component/ui/ChangeLogModal.tsx on lines 92..94

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 49.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function NewRootCmd has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            dbConfig db.Config,
                            config app.ServiceConfig,
                            cmdFactory cli.CommandFactory,
                            dbConnector db.Connector,
                            dbMigrationTool db.MigrationTool,
                        Severity: Minor
                        Found in backend/cmd/cmd.go - About 35 mins to fix

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                              try {
                                captchaResponse = await this.captchaService.execute(CREATE_CHANGE);
                              } catch (err) {
                                return Promise.reject(err);
                              }
                          Severity: Major
                          Found in frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts and 4 other locations - About 30 mins to fix
                          frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 154..158
                          frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 196..200
                          frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 81..85
                          frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 133..137

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                              try {
                                captchaResponse = await this.captchaService.execute(CREATE_SHORT_LINK);
                              } catch (err) {
                                return Promise.reject(err);
                              }
                          Severity: Major
                          Found in frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts and 4 other locations - About 30 mins to fix
                          frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 110..114
                          frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 154..158
                          frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 196..200
                          frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 133..137

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                              try {
                                captchaResponse = await this.captchaService.execute(DELETE_CHANGE);
                              } catch (err) {
                                return Promise.reject(err);
                              }
                          Severity: Major
                          Found in frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts and 4 other locations - About 30 mins to fix
                          frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 110..114
                          frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 154..158
                          frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 81..85
                          frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 133..137

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language