Sign upLogin

short-d/short

View on GitHub
Star

Showing 10 of 307 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  test('should render with correct placeholder', () => {
    const { container } = render(<TextAreaField placeholder={'placeholder'} />);
    const textarea = container.querySelector('textarea');

    expect(textarea).toBeTruthy();
Severity: Major
Found in frontend/src/component/form/TextAreaField.spec.tsx and 1 other location - About 2 hrs to fix
frontend/src/component/form/TextAreaField.spec.tsx on lines 10..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  test('should render with correct value', () => {
    const { container } = render(<TextAreaField value={'text'} />);
    const textarea = container.querySelector('textarea');

    expect(textarea).toBeTruthy();
Severity: Major
Found in frontend/src/component/form/TextAreaField.spec.tsx and 1 other location - About 2 hrs to fix
frontend/src/component/form/TextAreaField.spec.tsx on lines 18..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

interface IProps {
  text?: string;
  placeHolder?: string;
  onChange?: (text: string) => void;
  onBlur?: () => void;
Severity: Minor
Found in frontend/src/component/form/TextField.tsx and 1 other location - About 40 mins to fix
frontend/src/component/form/TextAreaField.tsx on lines 4..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

interface IProps {
  value?: string;
  placeholder?: string;
  onChange?: (value: string) => void;
  onBlur?: () => void;
Severity: Minor
Found in frontend/src/component/form/TextAreaField.tsx and 1 other location - About 40 mins to fix
frontend/src/component/form/TextField.tsx on lines 4..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          <div className={'close-icon'}>
            <Icon iconID={IconID.Close} onClick={this.handleCloseClick} />
          </div>
Severity: Minor
Found in frontend/src/component/pages/shared/ErrorModal.tsx and 1 other location - About 40 mins to fix
frontend/src/component/ui/ChangeLogModal.tsx on lines 92..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    try {
      captchaResponse = await this.captchaService.execute(CREATE_CHANGE);
    } catch (err) {
      return Promise.reject(err);
    }
Severity: Major
Found in frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts and 4 other locations - About 30 mins to fix
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 154..158
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 196..200
frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 81..85
frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 133..137

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    try {
      captchaResponse = await this.captchaService.execute(CREATE_SHORT_LINK);
    } catch (err) {
      return Promise.reject(err);
    }
Severity: Major
Found in frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts and 4 other locations - About 30 mins to fix
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 110..114
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 154..158
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 196..200
frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 133..137

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    try {
      captchaResponse = await this.captchaService.execute(DELETE_CHANGE);
    } catch (err) {
      return Promise.reject(err);
    }
Severity: Major
Found in frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts and 4 other locations - About 30 mins to fix
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 110..114
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 154..158
frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 81..85
frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 133..137

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    try {
      captchaResponse = await this.captchaService.execute(UPDATE_CHANGE);
    } catch (err) {
      return Promise.reject(err);
    }
Severity: Major
Found in frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts and 4 other locations - About 30 mins to fix
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 110..114
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 196..200
frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 81..85
frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 133..137

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    try {
      captchaResponse = await this.captchaService.execute(UPDATE_SHORT_LINK);
    } catch (err) {
      return Promise.reject(err);
    }
Severity: Major
Found in frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts and 4 other locations - About 30 mins to fix
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 110..114
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 154..158
frontend/src/service/shortGraphQL/ChangeLogGraphQL.api.ts on lines 196..200
frontend/src/service/shortGraphQL/ShortLinkGraphQL.api.ts on lines 81..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language