Sign upLogin

sibprogrammer/owp

View on GitHub
Star
app/controllers/sessions_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method new has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

  def new
    @available_locales = I18n.available_locales.map {
      |locale| [locale.to_s, I18n.t('language.title', :locale => locale) + " (#{locale})"]
    }.sort
Severity: Minor
Found in app/controllers/sessions_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method new has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def new
    @available_locales = I18n.available_locales.map {
      |locale| [locale.to_s, I18n.t('language.title', :locale => locale) + " (#{locale})"]
    }.sort
Severity: Major
Found in app/controllers/sessions_controller.rb - About 2 hrs to fix

    Method reset_password has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def reset_password
    if params.key?(:user_id) and params.key?(:hash)
      user = User.find(params[:user_id])
      if user
        hash = Digest::SHA1.hexdigest(user.crypted_password + user.login)
    Severity: Minor
    Found in app/controllers/sessions_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method restore_password has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def restore_password
    if request.post?
      user = User.find_by_login(params[:login])
      render(:json => { :success => false, :message => t('restore_password.error.user_not_found') }) and return if !user
      render(:json => { :success => false, :message => t('restore_password.error.no_email') }) and return if user.email.blank?
    Severity: Minor
    Found in app/controllers/sessions_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status