Sign upLogin

sibprogrammer/owp

View on GitHub
Star
app/models/backup.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method create_backup has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def self.create_backup(virtual_server, ve_state, description)
    orig_ve_state = virtual_server.state
    if 'running' == orig_ve_state
      case ve_state
        when 'suspend' then virtual_server.suspend
Severity: Minor
Found in app/models/backup.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method restore has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def restore
    orig_ve_state = virtual_server.state
    virtual_server.stop if 'running' == orig_ve_state

    job_id = restore_now['job_id']
Severity: Minor
Found in app/models/backup.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_backup has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.create_backup(virtual_server, ve_state, description)
    orig_ve_state = virtual_server.state
    if 'running' == orig_ve_state
      case ve_state
        when 'suspend' then virtual_server.suspend
Severity: Minor
Found in app/models/backup.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status