Sign upLogin

sibprogrammer/owp

View on GitHub
Star
app/models/hardware_server.rb

Summary

Maintainability
D
1 day
Test Coverage

Class HardwareServer has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

class HardwareServer < ActiveRecord::Base
  include ApplicationHelper

  attr_accessible :host, :auth_key, :description, :daemon_port, :use_ssl
  validates_uniqueness_of :host
Severity: Minor
Found in app/models/hardware_server.rb - About 2 hrs to fix

    File hardware_server.rb has 270 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class HardwareServer < ActiveRecord::Base
  include ApplicationHelper

  attr_accessible :host, :auth_key, :description, :daemon_port, :use_ssl
  validates_uniqueness_of :host
    Severity: Minor
    Found in app/models/hardware_server.rb - About 2 hrs to fix

      Method sync_virtual_servers has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        def sync_virtual_servers
    ves_on_server = rpc_client.exec('vzlist', '-a -H -o veid,hostname,ip,status')['output'].split("\n")
    # skip error lines
    ves_on_server = ves_on_server.find_all{ |item| item =~ /^\s*\d+/ }
      Severity: Minor
      Found in app/models/hardware_server.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method install_daemon has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def install_daemon(root_password)
    if root_password.blank?
      self.errors.add :root_password, :empty
      return false
    end
      Severity: Minor
      Found in app/models/hardware_server.rb - About 1 hr to fix

        Method sync_virtual_servers has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def sync_virtual_servers
    ves_on_server = rpc_client.exec('vzlist', '-a -H -o veid,hostname,ip,status')['output'].split("\n")
    # skip error lines
    ves_on_server = ves_on_server.find_all{ |item| item =~ /^\s*\d+/ }
        Severity: Minor
        Found in app/models/hardware_server.rb - About 1 hr to fix

          Method sync_backups has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def sync_backups
    backups_list = rpc_client.exec('ls', "--block-size=M -s #{backups_dir}")['output']
    backups_list = backups_list.split("\n")
    # remove totals line
    backups_list.shift
          Severity: Minor
          Found in app/models/hardware_server.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method prepare_daemon_config has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              def prepare_daemon_config(sftp, config_file)
      if !sftp_file_readable(sftp, config_file)
        upload_daemon_config(sftp, config_file)
      else
        sftp.file.open(config_file, "r") do |file|
          Severity: Minor
          Found in app/models/hardware_server.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method connect has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def connect(root_password = '')
    if !auth_key.blank?
      begin
        if !rpc_client.ping
          self.errors.add :auth_key, :bad_auth
          Severity: Minor
          Found in app/models/hardware_server.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method install_daemon has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def install_daemon(root_password)
    if root_password.blank?
      self.errors.add :root_password, :empty
      return false
    end
          Severity: Minor
          Found in app/models/hardware_server.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                return false
          Severity: Major
          Found in app/models/hardware_server.rb - About 30 mins to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                def generate_id
      symbols = [('0'..'9'),('a'..'f')].map{ |i| i.to_a }.flatten
      (1..32).map{ symbols[rand(symbols.length)] }.join
            Severity: Minor
            Found in app/models/hardware_server.rb and 2 other locations - About 15 mins to fix
            app/models/virtual_server.rb on lines 401..403
            utils/hw-daemon/hw-daemon.rb on lines 90..92

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status