Sign upLogin

sibprogrammer/owp

View on GitHub
Star
app/models/virtual_server.rb

Summary

Maintainability
D
2 days
Test Coverage

Method save_physically has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

  def save_physically
    return false if !valid?
    is_new = new_record?

    if is_new
Severity: Minor
Found in app/models/virtual_server.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File virtual_server.rb has 337 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class VirtualServer < ActiveRecord::Base
  attr_accessible :identity, :ip_address, :host_name, :hardware_server_id,
    :orig_os_template, :password, :start_on_boot, :start_after_creation, :state,
    :nameserver, :search_domain, :diskspace, :memory, :password_confirmation,
    :user_id, :orig_server_template, :description, :cpu_units, :cpus, :cpu_limit,
Severity: Minor
Found in app/models/virtual_server.rb - About 4 hrs to fix

    Class VirtualServer has 32 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class VirtualServer < ActiveRecord::Base
  attr_accessible :identity, :ip_address, :host_name, :hardware_server_id,
    :orig_os_template, :password, :start_on_boot, :start_after_creation, :state,
    :nameserver, :search_domain, :diskspace, :memory, :password_confirmation,
    :user_id, :orig_server_template, :description, :cpu_units, :cpus, :cpu_limit,
    Severity: Minor
    Found in app/models/virtual_server.rb - About 4 hrs to fix

      Method save_physically has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def save_physically
    return false if !valid?
    is_new = new_record?

    if is_new
      Severity: Major
      Found in app/models/virtual_server.rb - About 2 hrs to fix

        Method validate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def validate
    return if 0 == IpPool.count or ip_address.blank? or !ip_address_changed?
    return if 'auto' == ip_address

    old_ips = ip_address_was.blank? ? [] : ip_address_was.split(' ')
        Severity: Minor
        Found in app/models/virtual_server.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method save_limits has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def save_limits(limits)
    orig_limits = get_limits
    vzctl_params = ''
    limits.each do |limit|
      orig_limit = orig_limits.find { |item| item[:name] == limit['name'] }
        Severity: Minor
        Found in app/models/virtual_server.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method clone_physically has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def clone_physically(orig_server)
    return false if !valid?

    path = '/etc/vz/conf'
    hardware_server.rpc_client.exec("cp #{shellescape(path)}/#{shellescape(orig_server.identity.to_s)}.conf #{shellescape(path)}/#{shellescape(identity.to_s)}.conf")
        Severity: Minor
        Found in app/models/virtual_server.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_limits has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_limits
    parser = IniParser.new(hardware_server.rpc_client.exec('cat', "/etc/vz/conf/#{identity.to_s}.conf")['output'])

    limits = [
      'KMEMSIZE', 'LOCKEDPAGES', 'SHMPAGES', 'NUMPROC',
        Severity: Minor
        Found in app/models/virtual_server.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            def generate_id
      symbols = [('0'..'9'),('a'..'f')].map{ |i| i.to_a }.flatten
      (1..32).map{ symbols[rand(symbols.length)] }.join
        Severity: Minor
        Found in app/models/virtual_server.rb and 2 other locations - About 15 mins to fix
        app/models/hardware_server.rb on lines 277..279
        utils/hw-daemon/hw-daemon.rb on lines 90..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status