Sign upLogin

sibprogrammer/owp

View on GitHub
Star
utils/whmcs/owp/owp.php

Summary

Maintainability
D
2 days
Test Coverage

Method owp_CreateAccount has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function owp_CreateAccount($params)
{
    # ** The variables listed below are passed into all module functions **

    $serviceid = $params["serviceid"]; # Unique ID of the product/service in the WHMCS Database
Severity: Major
Found in utils/whmcs/owp/owp.php - About 2 hrs to fix

    Method owp_ConfigOptions has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function owp_ConfigOptions()
{
    $nodes = array();
    $serverTemplates = array();
    $osTempates = array();
    Severity: Minor
    Found in utils/whmcs/owp/owp.php - About 1 hr to fix

      Method _owp_apiCall has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function _owp_apiCall($method, $params = '') 
{
    $queryResult = mysql_query("SELECT * FROM `tblservers` WHERE `type` = 'owp' LIMIT 1");
    $serverInfo = mysql_fetch_array($queryResult);
      Severity: Minor
      Found in utils/whmcs/owp/owp.php - About 1 hr to fix

        Function owp_ConfigOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function owp_ConfigOptions()
{
    $nodes = array();
    $serverTemplates = array();
    $osTempates = array();
        Severity: Minor
        Found in utils/whmcs/owp/owp.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        function owp_SuspendAccount($params) 
{
    $username = $params["username"];
    $result = _owp_apiCall('users/get_by_login', array('login' => $username));
    $userId = (int)$result->id;
        Severity: Major
        Found in utils/whmcs/owp/owp.php and 2 other locations - About 5 hrs to fix
        utils/whmcs/owp/owp.php on lines 126..149
        utils/whmcs/owp/owp.php on lines 176..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 185.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        function owp_UnsuspendAccount($params) 
{
    $username = $params["username"];
    $result = _owp_apiCall('users/get_by_login', array('login' => $username));
    $userId = (int)$result->id;
        Severity: Major
        Found in utils/whmcs/owp/owp.php and 2 other locations - About 5 hrs to fix
        utils/whmcs/owp/owp.php on lines 126..149
        utils/whmcs/owp/owp.php on lines 151..174

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 185.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        function owp_TerminateAccount($params) 
{
    $username = $params["username"];
    $result = _owp_apiCall('users/get_by_login', array('login' => $username));
    $userId = (int)$result->id;
        Severity: Major
        Found in utils/whmcs/owp/owp.php and 2 other locations - About 5 hrs to fix
        utils/whmcs/owp/owp.php on lines 151..174
        utils/whmcs/owp/owp.php on lines 176..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 185.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status