Sign upLogin

sicambria/skilltree

View on GitHub
Star

Showing 537 of 537 total issues

Function getPublicUserData has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getPublicUserData(){
  var userToSearch = {value: document.getElementById('cardSearchBar').value};
  document.getElementById("searchModalTitle").innerHTML = "Click on a user, to view his/her main tree!";
  request('POST', '/protected/getPublicUserData', userToSearch, function() {
      if(this.readyState == 4 && this.status == 200) {
Severity: Minor
Found in new design/draft_offers_modal_design/user/src/search.js - About 1 hr to fix

    Function onclick has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

              row.onclick = function(){
            var foundmodal = document.getElementById('searchedSkillModal');
            var header = document.getElementById('searchedSkillModalHeader');
            var category = document.getElementById('searchedSkillModalCategory');
            var pdesc = document.getElementById('searchedSkillModalPDesc');
    Severity: Minor
    Found in public/user/src/search.js - About 1 hr to fix

      Function onclick has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                row.onclick = function(){
            var searchedUserModal = document.getElementById('searchedUserModal');
            var closeSearchedUserModal = document.getElementById('closeSearchedUserModal');
            var searchedUserModalHeader = document.getElementById('searchedUserModalHeader');
            var searchedUserlModalInfo = document.getElementById('searchedUserlModalInfo');
      Severity: Minor
      Found in new design/draft_create_skill_modal_design/user/src/search.js - About 1 hr to fix

        Function 2 has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            },{}],2:[function(require,module,exports){
    
    
    /**
     * ColorReplaceFilter, originally by mishaa, updated by timetocode
        Severity: Minor
        Found in new design/draft_create_skill_modal_design/user/pixi/pixi-extra-filters.js - About 1 hr to fix

          Function 2 has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              },{}],2:[function(require,module,exports){
    
    
    /**
     * ColorReplaceFilter, originally by mishaa, updated by timetocode
          Severity: Minor
          Found in new design/draft_offers_modal_design/user/pixi/pixi-extra-filters.js - About 1 hr to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                                    if (this.skills[i].itemcontainer.skillborder.endorsement != undefined) this.skills[i].itemcontainer.skillborder.endorsement.filters = [colorMatrixFilter];
            Severity: Major
            Found in new design/draft_create_skill_modal_design/user/classes/itemcontainer.js and 2 other locations - About 1 hr to fix
            new design/draft_offers_modal_design/user/classes/itemcontainer.js on lines 329..329
            public/user/classes/itemcontainer.js on lines 386..386

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            Object.assign(PIXI.DisplayObject.prototype, {
    parentLayer: null,
    _activeParentLayer: null,
    parentGroup: null,
    zOrder: 0,
            Severity: Major
            Found in new design/draft_offers_modal_design/user/pixi/pixi-layers.js and 1 other location - About 1 hr to fix
            new design/draft_create_skill_modal_design/user/pixi/pixi-layers.js on lines 36..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (parentNames != '') {
            parentNames = parentNames.substring(0, parentNames.length - 2);
            parents.innerText = parentNames;
        } else {
            parents.innerText = '-';
            Severity: Major
            Found in public/user/classes/itemcontainer.js and 2 other locations - About 1 hr to fix
            new design/draft_create_skill_modal_design/user/classes/itemcontainer.js on lines 674..679
            new design/draft_offers_modal_design/user/classes/itemcontainer.js on lines 690..695

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (parentNames != '') {
            parentNames = parentNames.substring(0, parentNames.length - 2);
            parents.innerText = parentNames;
        } else {
            parents.innerText = '-';
            Severity: Major
            Found in new design/draft_offers_modal_design/user/classes/itemcontainer.js and 2 other locations - About 1 hr to fix
            new design/draft_create_skill_modal_design/user/classes/itemcontainer.js on lines 674..679
            public/user/classes/itemcontainer.js on lines 714..719

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            Object.assign(PIXI.DisplayObject.prototype, {
    parentLayer: null,
    _activeParentLayer: null,
    parentGroup: null,
    zOrder: 0,
            Severity: Major
            Found in new design/draft_create_skill_modal_design/user/pixi/pixi-layers.js and 1 other location - About 1 hr to fix
            new design/draft_offers_modal_design/user/pixi/pixi-layers.js on lines 36..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                                    if (this.skills[i].itemcontainer.skillborder.endorsement != undefined) this.skills[i].itemcontainer.skillborder.endorsement.filters = [colorMatrixFilter];
            Severity: Major
            Found in public/user/classes/itemcontainer.js and 2 other locations - About 1 hr to fix
            new design/draft_create_skill_modal_design/user/classes/itemcontainer.js on lines 317..317
            new design/draft_offers_modal_design/user/classes/itemcontainer.js on lines 329..329

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                                    if (this.skills[i].itemcontainer.skillborder.endorsement != undefined) this.skills[i].itemcontainer.skillborder.endorsement.filters = [colorMatrixFilter];
            Severity: Major
            Found in new design/draft_offers_modal_design/user/classes/itemcontainer.js and 2 other locations - About 1 hr to fix
            new design/draft_create_skill_modal_design/user/classes/itemcontainer.js on lines 317..317
            public/user/classes/itemcontainer.js on lines 386..386

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (parentNames != '') {
            parentNames = parentNames.substring(0, parentNames.length - 2);
            parents.innerText = parentNames;
        } else {
            parents.innerText = '-';
            Severity: Major
            Found in new design/draft_create_skill_modal_design/user/classes/itemcontainer.js and 2 other locations - About 1 hr to fix
            new design/draft_offers_modal_design/user/classes/itemcontainer.js on lines 690..695
            public/user/classes/itemcontainer.js on lines 714..719

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function approveSkills has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function approveSkills() {
    hideMenus();

    var approveSkills = document.getElementById("approveSkills");
            Severity: Minor
            Found in public/user/chartandtree.js - About 1 hr to fix

              Function approveSkills has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function approveSkills() {
    hideAll();

    var approveSkills = document.getElementById("approveSkills");
              Severity: Minor
              Found in new design/draft_create_skill_modal_design/user/chartandtree.js - About 1 hr to fix

                Function approveSkills has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function approveSkills() {
    hideMenus();

    var approveSkills = document.getElementById("approveSkills");
                Severity: Minor
                Found in new design/draft_offers_modal_design/user/chartandtree.js - About 1 hr to fix

                  Function onClick has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      onClick(event) {
        if (!event.drag) {
            if (this.parentObj.self) {
                var children = this.parentObj.skill.children;
                  Severity: Minor
                  Found in new design/draft_create_skill_modal_design/user/classes/itemcontainer.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function editSkill has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function editSkill () {
    document.getElementById('newSkillForm').reset();

    var modal = document.getElementById("newSkillModal");
    modal.style.display = "block";
                  Severity: Minor
                  Found in public/user/chartandtree.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function editSkill has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function editSkill () {
    document.getElementById('newSkillForm').reset();

    var modal = document.getElementById("newSkillModal");
    modal.style.display = "block";
                  Severity: Minor
                  Found in new design/draft_offers_modal_design/user/chartandtree.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          for (var i = 0; foundUserSkills != undefined && i < foundUserSkills.length; i++) {
            resSkills.push({name: foundUserSkills[i].name});
        }
                  Severity: Major
                  Found in app.js and 1 other location - About 1 hr to fix
                  app.js on lines 291..293

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language