Sign upLogin

sicambria/skilltree

View on GitHub
Star

Showing 537 of 537 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                        this.setFilter(this.skills[i].itemcontainer, nullFilter, this.skills[i].itemcontainer.skillborder.filters[1]);
Severity: Major
Found in public/user/classes/itemcontainer.js and 3 other locations - About 40 mins to fix
new design/draft_offers_modal_design/user/classes/itemcontainer.js on lines 328..328
new design/draft_offers_modal_design/user/classes/itemcontainer.js on lines 336..336
public/user/classes/itemcontainer.js on lines 385..385

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                        this.setFilter(this.skills[i].itemcontainer, nullFilter, this.skills[i].itemcontainer.skillborder.filters[1]);
Severity: Major
Found in new design/draft_offers_modal_design/user/classes/itemcontainer.js and 3 other locations - About 40 mins to fix
new design/draft_offers_modal_design/user/classes/itemcontainer.js on lines 328..328
public/user/classes/itemcontainer.js on lines 385..385
public/user/classes/itemcontainer.js on lines 395..395

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (this.parentObj.skill.achievedPoint == this.parentObj.skill.maxPoint || this.parentObj.skill.disabled) return;
Severity: Minor
Found in public/user/classes/itemcontainer.js and 1 other location - About 40 mins to fix
public/user/classes/itemcontainer.js on lines 444..444

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (this.parentObj.skill.achievedPoint == this.parentObj.skill.maxPoint || this.parentObj.skill.disabled) return;
Severity: Minor
Found in public/user/classes/itemcontainer.js and 1 other location - About 40 mins to fix
public/user/classes/itemcontainer.js on lines 462..462

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                        this.setFilter(this.skills[i].itemcontainer, colorMatrixFilter, this.skills[i].itemcontainer.skillborder.filters[1]);
Severity: Major
Found in public/user/classes/itemcontainer.js and 3 other locations - About 40 mins to fix
new design/draft_offers_modal_design/user/classes/itemcontainer.js on lines 328..328
new design/draft_offers_modal_design/user/classes/itemcontainer.js on lines 336..336
public/user/classes/itemcontainer.js on lines 395..395

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                        this.setFilter(this.skills[i].itemcontainer, colorMatrixFilter, this.skills[i].itemcontainer.skillborder.filters[1]);
Severity: Major
Found in new design/draft_offers_modal_design/user/classes/itemcontainer.js and 3 other locations - About 40 mins to fix
new design/draft_offers_modal_design/user/classes/itemcontainer.js on lines 336..336
public/user/classes/itemcontainer.js on lines 385..385
public/user/classes/itemcontainer.js on lines 395..395

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    trainings: [
        {
            name: String,
            level: Number,
            shortDescription: String,
Severity: Minor
Found in models/skillmodel.js and 2 other locations - About 40 mins to fix
models/skillsforapprovemodel.js on lines 23..34
models/usermodel.js on lines 44..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    trainings: [
        {
            name: String,
            level: Number,
            shortDescription: String,
Severity: Minor
Found in models/skillsforapprovemodel.js and 2 other locations - About 40 mins to fix
models/skillmodel.js on lines 23..34
models/usermodel.js on lines 44..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    user.trees.push({
        name: treeToSort.name,
        focusArea: treeToSort.focusArea,
        description: treeToSort.description,
        skillNames: sn
Severity: Minor
Found in app.js and 2 other locations - About 40 mins to fix
app.js on lines 733..738
app.js on lines 785..790

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        user.trees.push({
                name: data.name,
                focusArea: data.focusArea,
                description: data.description,
                skillNames: sn
Severity: Minor
Found in app.js and 2 other locations - About 40 mins to fix
app.js on lines 567..572
app.js on lines 785..790

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            trainings: [
                {
                    name: String,
                    level: String,
                    shortDescription: String,
Severity: Minor
Found in models/usermodel.js and 2 other locations - About 40 mins to fix
models/skillmodel.js on lines 23..34
models/skillsforapprovemodel.js on lines 23..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        user.trees.push({
            name: data.name,
            focusArea: data.focusArea,
            description: data.description,
            skillNames: sn
Severity: Minor
Found in app.js and 2 other locations - About 40 mins to fix
app.js on lines 567..572
app.js on lines 733..738

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function render has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        render: function (displayObject, renderTexture, clear, transform, skipUpdateTransform) {
Severity: Minor
Found in new design/draft_create_skill_modal_design/user/pixi/pixi-layers.js - About 35 mins to fix

    Function _displayProcessInteractive has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            _displayProcessInteractive: function (point, displayObject, hitTestOrder, interactive, outOfMask) {
    Severity: Minor
    Found in new design/draft_create_skill_modal_design/user/pixi/pixi-layers.js - About 35 mins to fix

      Function GlowFilter has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          function GlowFilter(distance, outerStrength, innerStrength, color, quality) {
      Severity: Minor
      Found in new design/draft_create_skill_modal_design/user/pixi/pixi-extra-filters.js - About 35 mins to fix

        Function render has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                render: function (displayObject, renderTexture, clear, transform, skipUpdateTransform) {
        Severity: Minor
        Found in new design/draft_create_skill_modal_design/user/pixi/pixi-layers.js - About 35 mins to fix

          Function processInteractive has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  processInteractive: function (strangeStuff, displayObject, func, hitTest, interactive) {
          Severity: Minor
          Found in new design/draft_create_skill_modal_design/user/pixi/pixi-layers.js - About 35 mins to fix

            Function render has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    render: function (displayObject, renderTexture, clear, transform, skipUpdateTransform) {
            Severity: Minor
            Found in new design/draft_offers_modal_design/user/pixi/pixi-layers.js - About 35 mins to fix

              Function processInteractive has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      processInteractive: function (strangeStuff, displayObject, func, hitTest, interactive) {
              Severity: Minor
              Found in new design/draft_offers_modal_design/user/pixi/pixi-layers.js - About 35 mins to fix

                Function _displayProcessInteractive has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        _displayProcessInteractive: function (point, displayObject, hitTestOrder, interactive, outOfMask) {
                Severity: Minor
                Found in new design/draft_offers_modal_design/user/pixi/pixi-layers.js - About 35 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language