siemens/ngx-datatable

View on GitHub
projects/ngx-datatable/src/lib/utils/math.ts

Summary

Maintainability
D
2 days
Test Coverage

Function scaleColumns has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

function scaleColumns(colsByGroup: any, maxWidth: any, totalFlexGrow: any) {
  // calculate total width and flexgrow points for columns that can be resized
  for (const attr in colsByGroup) {
    if (colsByGroup.hasOwnProperty(attr)) {
      for (const column of colsByGroup[attr]) {
Severity: Minor
Found in projects/ngx-datatable/src/lib/utils/math.ts - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function forceFillColumnWidths has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

export function forceFillColumnWidths(
  allColumns: any[],
  expectedWidth: number,
  startIdx: number,
  allowBleed: boolean,
Severity: Minor
Found in projects/ngx-datatable/src/lib/utils/math.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function scaleColumns has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function scaleColumns(colsByGroup: any, maxWidth: any, totalFlexGrow: any) {
  // calculate total width and flexgrow points for columns that can be resized
  for (const attr in colsByGroup) {
    if (colsByGroup.hasOwnProperty(attr)) {
      for (const column of colsByGroup[attr]) {
Severity: Major
Found in projects/ngx-datatable/src/lib/utils/math.ts - About 2 hrs to fix

    Function forceFillColumnWidths has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function forceFillColumnWidths(
      allColumns: any[],
      expectedWidth: number,
      startIdx: number,
      allowBleed: boolean,
    Severity: Minor
    Found in projects/ngx-datatable/src/lib/utils/math.ts - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                if (column.canAutoResize && !hasMinWidth[column.prop]) {
                  const newWidth = column.width + column.flexGrow * widthPerFlexPoint;
                  if (column.minWidth !== undefined && newWidth < column.minWidth) {
                    remainingWidth += newWidth - column.minWidth;
                    column.width = column.minWidth;
      Severity: Major
      Found in projects/ngx-datatable/src/lib/utils/math.ts - About 45 mins to fix

        Consider simplifying this complex logical expression.
        Open

            if (
              (delta > 0 && (!col.maxWidth || col.width + delta <= col.maxWidth)) ||
              (delta < 0 && (!col.minWidth || col.width + delta >= col.minWidth))
            ) {
              col.width += delta;
        Severity: Major
        Found in projects/ngx-datatable/src/lib/utils/math.ts - About 40 mins to fix

          Function forceFillColumnWidths has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            allColumns: any[],
            expectedWidth: number,
            startIdx: number,
            allowBleed: boolean,
            defaultColWidth: number = 300
          Severity: Minor
          Found in projects/ngx-datatable/src/lib/utils/math.ts - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status