Sign upLogin

signmeup/signmeup

View on GitHub
Star

Showing 185 of 187 total issues

Similar blocks of code found in 12 locations. Consider refactoring.
Open

Tickets.deny({
  insert() {
    return true;
  },
  update() {
Severity: Major
Found in imports/api/tickets/tickets.js and 11 other locations - About 30 mins to fix
imports/api/announcements/announcements.js on lines 22..32
imports/api/announcements/announcements.js on lines 34..44
imports/api/courses/courses.js on lines 29..39
imports/api/courses/courses.js on lines 41..51
imports/api/locations/locations.js on lines 15..25
imports/api/locations/locations.js on lines 27..37
imports/api/queues/queues.js on lines 47..57
imports/api/queues/queues.js on lines 59..69
imports/api/sessions/sessions.js on lines 18..28
imports/api/sessions/sessions.js on lines 30..40
imports/api/tickets/tickets.js on lines 82..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

Announcements.deny({
  insert() {
    return true;
  },
  update() {
Severity: Major
Found in imports/api/announcements/announcements.js and 11 other locations - About 30 mins to fix
imports/api/announcements/announcements.js on lines 22..32
imports/api/courses/courses.js on lines 29..39
imports/api/courses/courses.js on lines 41..51
imports/api/locations/locations.js on lines 15..25
imports/api/locations/locations.js on lines 27..37
imports/api/queues/queues.js on lines 47..57
imports/api/queues/queues.js on lines 59..69
imports/api/sessions/sessions.js on lines 18..28
imports/api/sessions/sessions.js on lines 30..40
imports/api/tickets/tickets.js on lines 82..92
imports/api/tickets/tickets.js on lines 94..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

Announcements.allow({
  insert() {
    return false;
  },
  update() {
Severity: Major
Found in imports/api/announcements/announcements.js and 11 other locations - About 30 mins to fix
imports/api/announcements/announcements.js on lines 34..44
imports/api/courses/courses.js on lines 29..39
imports/api/courses/courses.js on lines 41..51
imports/api/locations/locations.js on lines 15..25
imports/api/locations/locations.js on lines 27..37
imports/api/queues/queues.js on lines 47..57
imports/api/queues/queues.js on lines 59..69
imports/api/sessions/sessions.js on lines 18..28
imports/api/sessions/sessions.js on lines 30..40
imports/api/tickets/tickets.js on lines 82..92
imports/api/tickets/tickets.js on lines 94..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  run({ ticketId }) {
    const ticket = Tickets.findOne(ticketId);
    if (!ticket || ticket.status === "deleted") {
      throw new Meteor.Error(
        "tickets.doesNotExist"`No ticket exists with id ${ticketId}`
Severity: Minor
Found in imports/api/tickets/methods.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onRendered has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

Template.SettingsCourses.onRendered(function onRendered() {
  this.autorun(() => {
    const courseId = FlowRouter.getQueryParam("course");
    if (!courseId && Meteor.user()) {
      const courses = Meteor.user()
Severity: Minor
Found in imports/ui/components/settings-courses/settings-courses.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Unknown word (CssSyntaxError)
Open

import { Meteor } from "meteor/meteor";
Severity: Minor
Found in imports/lib/both/notifications.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Meteor } from "meteor/meteor";
Severity: Minor
Found in imports/lib/both/users.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Meteor } from "meteor/meteor";
Severity: Minor
Found in imports/startup/client/tracking.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Meteor } from "meteor/meteor";
Severity: Minor
Found in imports/startup/server/fixtures.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Meteor } from "meteor/meteor";
Severity: Minor
Found in imports/ui/components/footer/footer.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Template } from "meteor/templating";
Severity: Minor
Found in imports/ui/components/modals/modal-queue-create/modal-queue-create.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Template } from "meteor/templating";
Severity: Minor
Found in imports/ui/components/queue-actions/queue-status-dropdown/queue-status-dropdown.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Meteor } from "meteor/meteor";
Severity: Minor
Found in imports/ui/components/settings-courses/settings-courses.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Locations } from "/imports/api/locations/locations";
Severity: Minor
Found in imports/api/locations/helpers.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Meteor } from "meteor/meteor";
Severity: Minor
Found in imports/api/locations/server/publications.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Meteor } from "meteor/meteor";
Severity: Minor
Found in imports/api/queues/server/publications.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Meteor } from "meteor/meteor";
Severity: Minor
Found in imports/api/tickets/methods.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Meteor } from "meteor/meteor";
Severity: Minor
Found in imports/api/locations/methods.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Mongo } from "meteor/mongo";
Severity: Minor
Found in imports/api/tickets/tickets.js by stylelint

Unknown word (CssSyntaxError)
Open

import { Mongo } from "meteor/mongo";
Severity: Minor
Found in imports/api/queues/queues.js by stylelint
Severity
Category
Status
Source
Language