Showing 9,050 of 9,050 total issues
AoConfig
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
public class AoConfig {
/*
* - Schema 实现类
* - Model 实现类
* - Record 实现类
Similar blocks of code found in 2 locations. Consider refactoring. Open
package io.horizon.uca.crypto;
import io.horizon.atom.common.KPair;
import io.horizon.eon.VValue;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 150.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
package io.horizon.uca.crypto;
import io.horizon.atom.common.KPair;
import io.horizon.eon.VValue;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 150.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method toString
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public String toString() {
StringBuilder sb = new StringBuilder("EAsset (");
sb.append(key);
Method hashCode
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public int hashCode() {
final int prime = 31;
int result = 1;
result = prime * result + ((this.key == null) ? 0 : this.key.hashCode());
File TVendorCheckInRecord.java
has 263 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*
* This file is generated by jOOQ.
*/
package cn.vertxup.erp.domain.tables.records;
File UObjectInternal.java
has 262 lines of code (exceeds 250 allowed). Consider refactoring. Open
package io.vertx.up.atom.typed;
import io.reactivex.rxjava3.core.Observable;
import io.vertx.core.json.JsonArray;
import io.vertx.core.json.JsonObject;
Method toJson
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public default io.vertx.core.json.JsonObject toJson() {
io.vertx.core.json.JsonObject json = new io.vertx.core.json.JsonObject();
json.put("KEY",getKey());
json.put("NAME",getName());
File JqAnalyzer.java
has 261 lines of code (exceeds 250 allowed). Consider refactoring. Open
package io.vertx.up.uca.jooq;
import io.horizon.eon.VString;
import io.horizon.eon.VValue;
import io.horizon.uca.cache.Cc;
File Ox.java
has 261 lines of code (exceeds 250 allowed). Consider refactoring. Open
package io.mature.extension.refine;
import cn.vertxup.ambient.domain.tables.pojos.XActivity;
import cn.vertxup.ambient.service.application.AppStub;
import cn.vertxup.ambient.service.application.InitStub;
Method invoker
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
public static Invoker invoker(final Class<?> returnType,
final Class<?> paramCls) {
Invoker invoker = null;
if (void.class == returnType || Void.class == returnType) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method isSame
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
private static boolean isSame(final Object valueOld, final Object valueNew, final Supplier<VsSame> supplier) {
if (Objects.isNull(valueOld) && Objects.isNull(valueNew)) {
/* ( Unchanged ) When `new` and `old` are both null */
return true;
} else {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method to
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
@Override
public Double to(final Object value, final Class<?> type) {
if (Objects.isNull(value)) {
return -1.0;
} else {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method convert
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
static JsonObject convert(
final JsonObject entity,
final ConcurrentMap<String, String> mapping,
final boolean immutable
) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method values
has 18 arguments (exceeds 4 allowed). Consider refactoring. Open
public EBrandRecord values(String value1, String value2, String value3, String value4, String value5, String value6, String value7, String value8, String value9, String value10, String value11, Boolean value12, String value13, String value14, LocalDateTime value15, String value16, LocalDateTime value17, String value18) {
Method values
has 18 arguments (exceeds 4 allowed). Consider refactoring. Open
public GNodeRecord values(String value1, String value2, BigDecimal value3, BigDecimal value4, String value5, String value6, String value7, String value8, String value9, String value10, String value11, String value12, Boolean value13, String value14, LocalDateTime value15, String value16, LocalDateTime value17, String value18) {
Method values
has 18 arguments (exceeds 4 allowed). Consider refactoring. Open
public SUserRecord values(String value1, String value2, String value3, String value4, String value5, String value6, String value7, String value8, String value9, String value10, String value11, String value12, Boolean value13, String value14, LocalDateTime value15, String value16, LocalDateTime value17, String value18) {
Method values
has 18 arguments (exceeds 4 allowed). Consider refactoring. Open
public SActionRecord values(String value1, String value2, String value3, String value4, String value5, Integer value6, String value7, String value8, String value9, String value10, String value11, Boolean value12, String value13, String value14, LocalDateTime value15, String value16, LocalDateTime value17, String value18) {
Method values
has 18 arguments (exceeds 4 allowed). Consider refactoring. Open
public XLogRecord values(String value1, String value2, String value3, String value4, String value5, String value6, LocalDateTime value7, String value8, String value9, String value10, Boolean value11, String value12, String value13, String value14, LocalDateTime value15, String value16, LocalDateTime value17, String value18) {
Method values
has 18 arguments (exceeds 4 allowed). Consider refactoring. Open
public XMenuRecord values(String value1, String value2, String value3, String value4, String value5, String value6, Long value7, Long value8, String value9, String value10, Boolean value11, String value12, String value13, String value14, LocalDateTime value15, String value16, LocalDateTime value17, String value18) {