Sign upLogin

silentbalanceyh/vertx-zero

View on GitHub
Star
vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java

Summary

Maintainability
D
2 days
Test Coverage

Method clazz has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    static Class<?> clazz(final String name, final Class<?> instanceCls, final ClassLoader loader) {
        if (TIs.isNil(name)) {
            return instanceCls;
        } else {
Severity: Minor
Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File HInstance.java has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package io.horizon.util;

import io.horizon.eon.VString;
import io.horizon.exception.internal.OperationException;
import io.horizon.fn.HFn;
Severity: Minor
Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 2 hrs to fix

    Method clazz has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static Class<?> clazz(final String name, final Class<?> instanceCls, final ClassLoader loader) {
        if (TIs.isNil(name)) {
            return instanceCls;
        } else {
    Severity: Minor
    Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 1 hr to fix

      Method typeWrap has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private static <T> Class<T> typeWrap(final Class<T> type) {
        if (type == null) {
            return null;
        } else if (type.isPrimitive()) {
            if (boolean.class == type) {
      Severity: Minor
      Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method typeMatch has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private static boolean typeMatch(final Class<?>[] declaredTypes, final Class<?>[] actualTypes) {
        if (declaredTypes.length == actualTypes.length) {
            for (int i = 0; i < actualTypes.length; i++) {
                if (actualTypes[i] == NULL.class) {
                    continue;
      Severity: Minor
      Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method constructor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @SuppressWarnings("unchecked")
    static <T> Constructor<T> constructor(final Class<?> clazz, final Object... params) {
        final int length = params.length;
        // Fix:Cannot invoke "java.util.concurrent.ConcurrentMap.getOrDefault(Object, Object)" because "map" is null
        final ConcurrentMap<Integer, Integer> map = BUILD_IN.getOrDefault(clazz, new ConcurrentHashMap<>());
      Severity: Minor
      Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                        return (Class<T>) Boolean.class;
        Severity: Major
        Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return (Class<T>) Byte.class;
          Severity: Major
          Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return (Class<T>) Integer.class;
            Severity: Major
            Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return null;
              Severity: Major
              Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return (Class<T>) Short.class;
                Severity: Major
                Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return (Class<T>) Long.class;
                  Severity: Major
                  Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return type;
                    Severity: Major
                    Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                      if (Objects.isNull(clazz)) {
                    try {
                        clazz = ClassLoader.getSystemClassLoader().loadClass(name);
                    } catch (final Throwable ex) {
                        LOGGER.error("[T] (System) Error occurs in reflection, details: {}",
                      Severity: Minor
                      Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java and 1 other location - About 35 mins to fix
                      vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java on lines 126..133

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 44.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                      if (Objects.isNull(clazz)) {
                    try {
                        clazz = ClassLoader.getPlatformClassLoader().loadClass(name);
                    } catch (final Throwable ex) {
                        LOGGER.error("[T] (Platform) Error occurs in reflection, details: {}",
                      Severity: Minor
                      Found in vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java and 1 other location - About 35 mins to fix
                      vertx-gaia/vertx-ams/src/main/java/io/horizon/util/HInstance.java on lines 117..124

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 44.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status