Sign upLogin

silentbalanceyh/vertx-zero

View on GitHub
Star
vertx-gaia/vertx-ams/src/main/jib/io/horizon/spi/cloud/HED.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method generate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static String generate(final String packageName, final String className, final int length) {
        final KPair pair = HUt.randomRsa(length);
        // PRIVATE_KEY
        final List<String> source = new ArrayList<>();
        source.add("package " + packageName + ";");
Severity: Minor
Found in vertx-gaia/vertx-ams/src/main/jib/io/horizon/spi/cloud/HED.java - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            {
            // PRIVATE_KEY
            source.add(VString.EMPTY);
            final StringBuilder strPri = new StringBuilder();
            strPri.append("    private static final String PRIVATE_KEY = \"");
    Severity: Major
    Found in vertx-gaia/vertx-ams/src/main/jib/io/horizon/spi/cloud/HED.java and 1 other location - About 1 hr to fix
    vertx-gaia/vertx-ams/src/main/jib/io/horizon/spi/cloud/HED.java on lines 63..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            {
            // PUBLIC_KEY
            source.add(VString.EMPTY);
            final StringBuilder strPub = new StringBuilder();
            strPub.append("    private static final String PUBLIC_KEY = \"");
    Severity: Major
    Found in vertx-gaia/vertx-ams/src/main/jib/io/horizon/spi/cloud/HED.java and 1 other location - About 1 hr to fix
    vertx-gaia/vertx-ams/src/main/jib/io/horizon/spi/cloud/HED.java on lines 75..86

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status