Sign upLogin

silentbalanceyh/vertx-zero

View on GitHub
Star
vertx-gaia/vertx-co/src/main/java/io/vertx/up/commune/record/Apt.java

Summary

Maintainability
C
1 day
Test Coverage

Apt has 43 methods (exceeds 20 allowed). Consider refactoring.
Open

@SuppressWarnings("unchecked")
public class Apt {
    private final static Annal LOGGER = Annal.get(Apt.class);

    private final static String MSG_APT_BATCH = "Current api does not support `isBatch = false`. Method = {0}";
Severity: Minor
Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/commune/record/Apt.java - About 5 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private JsonArray dataS(final Boolean append) {
        return this.doBatch(() -> {
            final JsonArray add = ((AptBatch) this.batch).dataAdd();
            final JsonArray appended = this.batch.dataA();
            final JsonArray replaced = this.batch.dataS();
    Severity: Major
    Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/commune/record/Apt.java and 1 other location - About 1 hr to fix
    vertx-gaia/vertx-co/src/main/java/io/vertx/up/commune/record/Apt.java on lines 340..351

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private JsonArray dataK(final Boolean append) {
        return this.doBatch(() -> {
            final JsonArray deleted = ((AptBatch) this.batch).dataDelete();
            final JsonArray appended = this.batch.dataA();
            final JsonArray replaced = this.batch.dataS();
    Severity: Major
    Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/commune/record/Apt.java and 1 other location - About 1 hr to fix
    vertx-gaia/vertx-co/src/main/java/io/vertx/up/commune/record/Apt.java on lines 363..374

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Fluent
    public Apt comparedA(final JsonArray inserted) {
        this.doBatch(() -> {
            final JsonArray normalized = Ut.valueJArray(inserted);
            this.compared.put(ChangeFlag.ADD, normalized);
    Severity: Minor
    Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/commune/record/Apt.java and 1 other location - About 35 mins to fix
    vertx-gaia/vertx-co/src/main/java/io/vertx/up/commune/record/Apt.java on lines 270..277

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Fluent
    public Apt comparedU(final JsonArray updated) {
        this.doBatch(() -> {
            final JsonArray normalized = Ut.valueJArray(updated);
            this.compared.put(ChangeFlag.UPDATE, normalized);
    Severity: Minor
    Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/commune/record/Apt.java and 1 other location - About 35 mins to fix
    vertx-gaia/vertx-co/src/main/java/io/vertx/up/commune/record/Apt.java on lines 257..264

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status