Sign upLogin

silentbalanceyh/vertx-zero

View on GitHub
Star
vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java

Summary

Maintainability
C
1 day
Test Coverage

File Jackson.java has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package io.vertx.up.util;

import io.horizon.eon.VString;
import io.horizon.eon.VValue;
import io.horizon.eon.em.typed.ChangeFlag;
Severity: Minor
Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java - About 2 hrs to fix

    Jackson has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    @SuppressWarnings("all")
final class Jackson {
    private static final Annal LOGGER = Annal.get(Jackson.class);

    private Jackson() {
    Severity: Minor
    Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java - About 2 hrs to fix

      Method searchData has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static <T> T searchData(final JsonObject data,
                                    final Class<T> clazz,
                                    final String... pathes) {
        if (null == data || VValue.ZERO == pathes.length) {
            return null;
      Severity: Minor
      Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java - About 1 hr to fix

        Method aiJArray has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            static String aiJArray(final String literal) {
        if (literal.contains(VString.QUOTE_DOUBLE)) {
            return literal;
        } else {
            final StringBuilder buffer = new StringBuilder();
        Severity: Minor
        Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java - About 1 hr to fix

          Method flag has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              static ChangeFlag flag(final JsonObject recordN, final JsonObject recordO) {
        if (HUt.isNil(recordO)) {
            if (HUt.isNil(recordN)) {
                return ChangeFlag.NONE;
            } else {
          Severity: Minor
          Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method deserializeSmart has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private static <T> String deserializeSmart(final String literal, final Class<T> type) {
        if (HUt.isJObject(literal) || HUt.isJArray(literal)) {
            if (HUt.isJArray(literal)) {
                return deserializeSmart(new JsonArray(literal), type);
            } else {
          Severity: Minor
          Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method zip has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              static <T> JsonArray zip(final JsonArray array, final String fieldFrom,
                             final String fieldOn,
                             final ConcurrentMap<T, JsonArray> grouped, final String fieldTo) {
          Severity: Minor
          Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                static JsonArray visitJArray(
        final JsonObject item,
        final String... keys
    ) {
        final JsonArray visited = Jackson.searchData(item, JsonArray.class, keys);
            Severity: Minor
            Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java and 1 other location - About 30 mins to fix
            vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java on lines 27..38

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 41.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                static JsonObject visitJObject(
        final JsonObject item,
        final String... keys
    ) {
            Severity: Minor
            Found in vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java and 1 other location - About 30 mins to fix
            vertx-gaia/vertx-co/src/main/java/io/vertx/up/util/Jackson.java on lines 47..57

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 41.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status