Sign upLogin

silentbalanceyh/vertx-zero

View on GitHub
Star
vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method ruleApt has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static Apt ruleApt(final JsonArray twins, final boolean isReplaced) {
        final JsonArray oldQueue = new JsonArray();
        final JsonArray newQueue = new JsonArray();
        final JsonArray updatedQueue = new JsonArray();
        final JsonArray addQueue = new JsonArray();
Severity: Minor
Found in vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java - About 1 hr to fix

    Method ruleMatch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private static boolean ruleMatch(final KRuleTerm rule, final JsonObject recordL, final JsonObject recordR) {
        if (Objects.isNull(rule)) {
            /* Compare record directly */
            return recordL.equals(recordR);
        } else {
    Severity: Minor
    Found in vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static JsonObject ruleAll(final Collection<KRuleTerm> rules, final JsonObject recordO, final JsonObject recordN) {
        final boolean isMatch = rules.stream().allMatch(rule -> ruleMatch(rule, recordO, recordN));
        return isMatch ? ruleTwins(recordO, recordN) : null;
    }
    Severity: Minor
    Found in vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java and 1 other location - About 35 mins to fix
    vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java on lines 45..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static JsonObject ruleAny(final Collection<KRuleTerm> rules, final JsonObject recordO, final JsonObject recordN) {
        final boolean isMatch = rules.stream().anyMatch(rule -> ruleMatch(rule, recordO, recordN));
        return isMatch ? ruleTwins(recordO, recordN) : null;
    }
    Severity: Minor
    Found in vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java and 1 other location - About 35 mins to fix
    vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java on lines 30..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                        newRecord.fieldNames().stream().filter(key -> Objects.nonNull(newRecord.getValue(key)))
                        .forEach(key -> merged.put(key, newRecord.getValue(key)));
    Severity: Major
    Found in vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java and 3 other locations - About 30 mins to fix
    vertx-gaia/vertx-ams/src/main/modeler/io/modello/atom/normalize/KRuleTerm.java on lines 68..70
    vertx-pin/zero-atom/src/main/modulat/io/vertx/mod/atom/refine/AoData.java on lines 53..55
    vertx-pin/zero-vie/src/main/java/io/mature/extension/scaffold/stdn/HDiff.java on lines 110..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static JsonObject ruleAll(final Collection<KRuleTerm> rules, final JsonObject input) {
        final boolean isMatch = rules.stream().allMatch(term -> Objects.nonNull(term.dataMatch(input)));
        return isMatch ? input : null;
    }
    Severity: Minor
    Found in vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java and 1 other location - About 30 mins to fix
    vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java on lines 40..43

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static JsonObject ruleAny(final Collection<KRuleTerm> rules, final JsonObject input) {
        final boolean isMatch = rules.stream().anyMatch(term -> Objects.nonNull(term.dataMatch(input)));
        return isMatch ? input : null;
    }
    Severity: Minor
    Found in vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java and 1 other location - About 30 mins to fix
    vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java on lines 25..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static JsonObject ruleAny(final Collection<KRuleTerm> rules, final JsonArray source, final JsonObject record) {
        return Ut.itJArray(source).map(recordR -> ruleAny(rules, record, recordR))
            .filter(Objects::nonNull).findFirst().orElse(null);
    }
    Severity: Minor
    Found in vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java and 1 other location - About 30 mins to fix
    vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java on lines 35..38

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static JsonObject ruleAll(final Collection<KRuleTerm> rules, final JsonArray source, final JsonObject record) {
        return Ut.itJArray(source).map(recordR -> ruleAll(rules, record, recordR))
            .filter(Objects::nonNull).findFirst().orElse(null);
    }
    Severity: Minor
    Found in vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java and 1 other location - About 30 mins to fix
    vertx-gaia/vertx-up/src/main/java/io/vertx/up/unity/Unique.java on lines 50..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status