Sign upLogin

silentbalanceyh/vertx-zero

View on GitHub
Star
vertx-gaia/vertx-up/src/main/jib/io/vertx/up/uca/job/phase/Input.java

Summary

Maintainability
A
1 hr
Test Coverage

Method inputAsync has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    Future<Envelop> inputAsync(final Mission mission) {
        /*
         * Get income address
         * 1) If there configured income address, it means that there are some inputs came from
         *     'incomeAddress' ( For feature usage )
Severity: Minor
Found in vertx-gaia/vertx-up/src/main/jib/io/vertx/up/uca/job/phase/Input.java - About 1 hr to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            } else {
            Element.onceLog(mission, () -> LOGGER.info(VMessage.Job.PHASE.ERROR_TERMINAL, mission.getCode(), envelop.error().getClass().getName()));
            return Ux.future(envelop);
        }
    Severity: Minor
    Found in vertx-gaia/vertx-up/src/main/jib/io/vertx/up/uca/job/phase/Input.java and 2 other locations - About 35 mins to fix
    vertx-gaia/vertx-up/src/main/jib/io/vertx/up/uca/job/phase/OutPut.java on lines 95..101
    vertx-gaia/vertx-up/src/main/jib/io/vertx/up/uca/job/phase/RunOn.java on lines 68..71

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status