Sign upLogin

silentbalanceyh/vertx-zero

View on GitHub
Star
vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/ExcelClientImpl.java

Summary

Maintainability
C
7 hrs
Test Coverage

ExcelClientImpl has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ExcelClientImpl implements ExcelClient {

    private static final Annal LOGGER = Annal.get(ExcelClientImpl.class);

    private transient final Vertx vertx;
Severity: Minor
Found in vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/ExcelClientImpl.java - About 4 hrs to fix

    Method importAsync has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public <T> ExcelClient importAsync(final InputStream in, final boolean isXlsx, final HMetaAtom metaAtom, final Handler<AsyncResult<Set<T>>> handler, final String... includes) {
    Severity: Minor
    Found in vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/ExcelClientImpl.java - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Override
    public <T> ExcelClient importAsync(final String filename, final HMetaAtom metaAtom, final Handler<AsyncResult<Set<T>>> handler, final String... includes) {
        return this.ingest(filename, metaAtom, res -> handler.handle(this.importer.importAsync(this.ingest.compressAsync(res.result(), includes))));
    }
      Severity: Minor
      Found in vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/ExcelClientImpl.java and 1 other location - About 35 mins to fix
      vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/ExcelClientImpl.java on lines 221..224

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Override
    public <T> ExcelClient importAsync(final InputStream in, final boolean isXlsx, final Handler<AsyncResult<Set<T>>> handler, final String... includes) {
        return this.ingest(in, isXlsx, res -> handler.handle(this.importer.importAsync(this.ingest.compressAsync(res.result(), includes))));
    }
      Severity: Minor
      Found in vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/ExcelClientImpl.java and 1 other location - About 35 mins to fix
      vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/ExcelClientImpl.java on lines 216..219

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Override
    public <T> Future<Set<T>> importAsync(final String filename, final HMetaAtom metaAtom, final String... includes) {
        return this.ingestAsync(filename, metaAtom).compose(tables -> this.ingest.compressAsync(tables, includes)).compose(this.importer::importAsync);
    }
      Severity: Minor
      Found in vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/ExcelClientImpl.java and 1 other location - About 30 mins to fix
      vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/ExcelClientImpl.java on lines 241..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Override
    public <T> Future<Set<T>> importAsync(final InputStream in, final boolean isXlsx, final String... includes) {
        return this.ingestAsync(in, isXlsx).compose(tables -> this.ingest.compressAsync(tables, includes)).compose(this.importer::importAsync);
    }
      Severity: Minor
      Found in vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/ExcelClientImpl.java and 1 other location - About 30 mins to fix
      vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/ExcelClientImpl.java on lines 236..239

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status