silentbalanceyh/vertx-zero

View on GitHub
vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/tool/ExData.java

Summary

Maintainability
B
6 hrs
Test Coverage

Method generateHeader has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static boolean generateHeader(final Sheet sheet, final String identifier,
                                  final JsonArray tableData, final HMetaAtom metaAtom) {
        final Consumer<Integer> consumer = width -> {
            /*
             * Row creation

    Method generateHeader has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        static boolean generateHeader(final Sheet sheet, final String identifier,
                                      final JsonArray tableData, final HMetaAtom metaAtom) {
            final Consumer<Integer> consumer = width -> {
                /*
                 * Row creation

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method createCell has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private static void createCell(final Sheet sheet, final Row row,
                                       final ExPos pos, final Object value, final Class<?> type) {

      Method createCell has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private static void createCell(final Row row, final Integer index, final Object value, final Class<?> typeDef) {
              if (Objects.isNull(value)) {
                  /* Cell create */
                  final Cell cell = row.createCell(index);
                  /* null filling */

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method createCell has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private static void createCell(final Sheet sheet, final Row row,
                                         final ExPos pos, final Object value, final Class<?> type) {
              if (value instanceof JsonObject) {
                  /*
                   * Json Format

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              } else {
                  if (VValue.TWO <= tableData.size()) {
                      /*
                       * 0, 1 processing
                       */
      vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/tool/ExData.java on lines 88..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (metaAtom.isComplex()) {
                  /*
                   * Complex workflow processing
                   */
                  if (VValue.FOUR <= tableData.size()) {
      vertx-ifx/zero-ifx-excel/src/main/java/io/vertx/up/plugin/excel/tool/ExData.java on lines 103..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status