Sign upLogin

silentbalanceyh/vertx-zero

View on GitHub
Star
vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/UnityAmbient.java

Summary

Maintainability
C
1 day
Test Coverage

Method connect has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private JsonObject connect(final XApp app, final XSource source) {
        final JsonObject normalized = new JsonObject();
        /* ID */
        {
            /*
Severity: Major
Found in vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/UnityAmbient.java - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            {
            /*
             * Deployment information
             * Back-End
             * domain - application domain information that will be deployed
    Severity: Major
    Found in vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/UnityAmbient.java and 1 other location - About 2 hrs to fix
    vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/_RegistryKit.java on lines 114..139

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 134.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            {
            /*
             * Auditor information of current application.
             * createdAt, createdBy
             * updatedAt, updatedBy
    Severity: Major
    Found in vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/UnityAmbient.java and 1 other location - About 1 hr to fix
    vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/_RegistryKit.java on lines 141..153

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            {
            /* Major: Logo and Title */
            normalized.put(KName.App.LOGO, app.getLogo());
            normalized.put(KName.App.TITLE, app.getTitle());
            /*
    Severity: Major
    Found in vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/UnityAmbient.java and 1 other location - About 1 hr to fix
    vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/_RegistryKit.java on lines 95..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            {
            /*
             * 3 Fields of identifiers
             * sigma - Cross module to identify application / container here.
             * appId - Inner ambient environment to identify application.
    Severity: Major
    Found in vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/UnityAmbient.java and 3 other locations - About 50 mins to fix
    vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/UnityAmbient.java on lines 91..104
    vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/_RegistryKit.java on lines 67..78
    vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/_RegistryKit.java on lines 80..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            {
            /*
             * System information of application
             * 「Front App」
             * name - the unique name that will be used in front environment variable.  Z_APP
    Severity: Major
    Found in vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/UnityAmbient.java and 3 other locations - About 50 mins to fix
    vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/UnityAmbient.java on lines 78..89
    vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/_RegistryKit.java on lines 67..78
    vertx-pin/zero-ambient/src/main/jib/io/horizon/spi/environment/_RegistryKit.java on lines 80..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status