Sign upLogin

silentbalanceyh/vertx-zero

View on GitHub
Star
vertx-pin/zero-vie/src/main/jib/io/mature/extension/uca/log/AtRunner.java

Summary

Maintainability
C
1 day
Test Coverage

Method executeAsync has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    Future<JsonObject> executeAsync(final JsonObject oldRecord, final JsonObject newRecord,
                                    final JsonObject activityJson, final Set<String> ignoreSet) {
        /*
         * 主单据变更类型，
         * 先计算 modelKey
Severity: Minor
Found in vertx-pin/zero-vie/src/main/jib/io/mature/extension/uca/log/AtRunner.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method executeAsync has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    Future<JsonObject> executeAsync(final JsonObject oldRecord, final JsonObject newRecord,
                                    final JsonObject activityJson, final Set<String> ignoreSet) {
        /*
         * 主单据变更类型，
         * 先计算 modelKey
Severity: Major
Found in vertx-pin/zero-vie/src/main/jib/io/mature/extension/uca/log/AtRunner.java - About 2 hrs to fix

    Method toChanges has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private List<XActivityChange> toChanges(final JsonObject oldRecord, final JsonObject newRecord,
                                            final ChangeFlag flag, final DataAtom atom, final Set<String> ignores) {
        final List<XActivityChange> changes = new ArrayList<>();
        if (ChangeFlag.NONE != flag) {
            // Vs 引用获取
    Severity: Major
    Found in vertx-pin/zero-vie/src/main/jib/io/mature/extension/uca/log/AtRunner.java - About 2 hrs to fix

      Method onSet has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private Set<String> onSet(final Set<String> fieldSet, final DataAtom atom,
                              final Set<String> ignoreSet,
                              final Function<String, Object> valueFn,
                              final BiPredicate<Object, String> valuePre) {
      Severity: Minor
      Found in vertx-pin/zero-vie/src/main/jib/io/mature/extension/uca/log/AtRunner.java - About 35 mins to fix

        Method toChanges has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private List<XActivityChange> toChanges(final JsonObject oldRecord, final JsonObject newRecord,
                                            final ChangeFlag flag, final DataAtom atom, final Set<String> ignores) {
        Severity: Minor
        Found in vertx-pin/zero-vie/src/main/jib/io/mature/extension/uca/log/AtRunner.java - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      } else if (ChangeFlag.DELETE == flag) {

                /* 主记录删除 */
                final Set<String> deleted = this.onSet(oldRecord.fieldNames(), atom, ignores, oldRecord::getValue);
                this.onAttribute(deleted, atom, (attrName, change) -> {
          Severity: Major
          Found in vertx-pin/zero-vie/src/main/jib/io/mature/extension/uca/log/AtRunner.java and 1 other location - About 1 hr to fix
          vertx-pin/zero-vie/src/main/jib/io/mature/extension/uca/log/AtRunner.java on lines 193..203

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (ChangeFlag.ADD == flag) {

                /* 主记录添加 */
                final Set<String> added = this.onSet(newRecord.fieldNames(), atom, ignores, newRecord::getValue);
                this.onAttribute(added, atom, (attrName, change) -> {
          Severity: Major
          Found in vertx-pin/zero-vie/src/main/jib/io/mature/extension/uca/log/AtRunner.java and 1 other location - About 1 hr to fix
          vertx-pin/zero-vie/src/main/jib/io/mature/extension/uca/log/AtRunner.java on lines 203..213

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status