silentrob/superscript

View on GitHub

Showing 92 of 92 total issues

Avoid too many return statements within this function.
Open

      return processWordnetLookup(tag, replyObj, options);
Severity: Major
Found in src/bot/processTags.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return processSetState(tag, replyObj, options);
    Severity: Major
    Found in src/bot/processTags.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return processClearConversation(tag, replyObj, options);
      Severity: Major
      Found in src/bot/processTags.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return processDelay(tag, replyObj, options);
        Severity: Major
        Found in src/bot/processTags.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return 'unknown';
          Severity: Major
          Found in src/plugins/time.js - About 30 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              try {
                cleanedArgs = safeEval(tag.functionArgs);
              } catch (err) {
                throw new Error(`Error processing respond args: ${err}`);
              }
            Severity: Minor
            Found in src/bot/processTags.js and 2 other locations - About 30 mins to fix
            src/bot/processTags.js on lines 215..219
            src/bot/processTags.js on lines 260..264

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                  return helpers.findMatchingGambitsForMessage('reply', reply, messageObject, options);
            Severity: Major
            Found in src/bot/getReply/index.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return false;
              Severity: Major
              Found in src/bot/getReply/index.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return false;
                Severity: Major
                Found in src/bot/getReply/index.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return processRedirect(tag, replyObj, options);
                  Severity: Major
                  Found in src/bot/processTags.js - About 30 mins to fix

                    Function createTopicModel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    const createTopicModel = function createTopicModel(db) {
                      const topicSchema = new mongoose.Schema({
                        name: { type: String, index: true, unique: true },
                    
                        system: { type: Boolean, default: false },
                    Severity: Minor
                    Found in src/bot/db/models/topic.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getSeason has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    const getSeason = function getSeason() {
                      const now = moment();
                      now.dayOfYear();
                      const doy = now.dayOfYear();
                    
                    
                    Severity: Minor
                    Found in src/plugins/time.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language