Sign upLogin

silverbux/laravel-angular-admin

View on GitHub
Star

Showing 96 of 96 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

angular.module('app.components')
  .component('tablesSimple', TablesSimpleComponent)
  .component('uiModal', UiModalComponent)
  .component('uiTimeline', UiTimelineComponent)
  .component('uiButtons', UiButtonsComponent)
Severity: Major
Found in angular/index.components.js and 1 other location - About 1 hr to fix
angular/index.filters.js on lines 9..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

angular.module('app.filters')
  .filter('datemillis', DateMillisFilter)
  .filter('capitalize', CapitalizeFilter)
  .filter('humanreadable', HumanReadableFilter)
  .filter('truncateCharacters', TruncatCharactersFilter)
Severity: Major
Found in angular/index.filters.js and 1 other location - About 1 hr to fix
angular/index.components.js on lines 30..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method run has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        DB::table('permission_role')->insert([
            [
                'id' => 1,
Severity: Minor
Found in database/seeds/PermissionRoleTableSeeder.php - About 1 hr to fix

    Method putMe has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function putMe(Request $request)
    {
        $user = Auth::user();

        $this->validate($request, [
    Severity: Minor
    Found in app/Http/Controllers/UserController.php - About 1 hr to fix

      Method run has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function run()
    {
        DB::table('roles')->insert([
            [
                'id' => 1,
      Severity: Minor
      Found in database/seeds/RolesTableSeeder.php - About 1 hr to fix

        Function RoutesRun has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function RoutesRun ($rootScope, $state, $auth, AclService, $timeout, API, ContextService) {
  'ngInject'

  AclService.resume()
        Severity: Minor
        Found in angular/run/routes.run.js - About 1 hr to fix

          Function constructor has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            constructor ($scope, $state, $compile, DTOptionsBuilder, DTColumnBuilder, API) {
    'ngInject'
    this.API = API
    this.$state = $state
          Severity: Minor
          Found in angular/app/components/user-lists/user-lists.component.js - About 1 hr to fix

            Function constructor has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              constructor ($scope, $state, $compile, DTOptionsBuilder, DTColumnBuilder, API) {
    'ngInject'
    this.API = API
    this.$state = $state
            Severity: Minor
            Found in angular/app/components/user-roles/user-roles.component.js - About 1 hr to fix

              Function constructor has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                constructor ($scope, $state, $compile, DTOptionsBuilder, DTColumnBuilder, API) {
    'ngInject'
    this.API = API
    this.$state = $state
              Severity: Minor
              Found in angular/app/components/user-permissions/user-permissions.component.js - About 1 hr to fix

                Function constructor has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  constructor ($stateParams, $state, API) {
    'ngInject'

    this.$state = $state
    this.formSubmitted = false
                Severity: Minor
                Found in angular/app/components/user-edit/user-edit.component.js - About 1 hr to fix

                  Function passwordVerifyClass has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function passwordVerifyClass () {
  return {
    require: 'ngModel',
    scope: {
      passwordVerify: '='
                  Severity: Minor
                  Found in angular/directives/password-verify/password-verify.component.js - About 1 hr to fix

                    Function getRolesAbilities has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function getRolesAbilities()
    {
        $abilities = [];
        $roles = Role::all();
                    Severity: Minor
                    Found in app/Http/Controllers/Auth/AuthController.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function run()
    {
        DB::table('role_user')->insert([
            [
                'id' => 1,
                    Severity: Minor
                    Found in database/seeds/RoleUserTableSeeder.php - About 1 hr to fix

                      Function constructor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        constructor ($stateParams, $state, API) {
    'ngInject'

    this.$state = $state
    this.formSubmitted = false
                      Severity: Minor
                      Found in angular/app/components/user-roles-edit/user-roles-edit.component.js - About 1 hr to fix

                        Function constructor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          constructor (Restangular, $window) {
    'ngInject'
    // content negotiation
    var headers = {
      'Content-Type': 'application/json',
                        Severity: Minor
                        Found in angular/services/API.service.js - About 1 hr to fix

                          Function delete has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            delete (permissionId) {
    let API = this.API
    let $state = this.$state

    swal({
                          Severity: Minor
                          Found in angular/app/components/user-permissions/user-permissions.component.js - About 1 hr to fix

                            Function delete has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              delete (userId) {
    let API = this.API
    let $state = this.$state

    swal({
                            Severity: Minor
                            Found in angular/app/components/user-lists/user-lists.component.js - About 1 hr to fix

                              Function delete has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                delete (roleId) {
    let API = this.API
    let $state = this.$state

    swal({
                              Severity: Minor
                              Found in angular/app/components/user-roles/user-roles.component.js - About 1 hr to fix

                                Similar blocks of code found in 4 locations. Consider refactoring.
                                Open

                                  $stateProvider
    .state('app', {
      abstract: true,
      views: {
        'layout': {
                                Severity: Major
                                Found in angular/config/routes.config.js and 3 other locations - About 55 mins to fix
                                angular/config/routes.config.js on lines 14..316
                                angular/config/routes.config.js on lines 14..343
                                angular/config/routes.config.js on lines 14..356

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 53.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Function RoutesRun has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                export function RoutesRun ($rootScope, $state, $auth, AclService, $timeout, API, ContextService) {
                                Severity: Major
                                Found in angular/run/routes.run.js - About 50 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language