Sign upLogin

siment/magento2-http-header-theme-switch

View on GitHub
Star

Showing 4 of 4 total issues

Method testAfterGetThemeByRequest has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testAfterGetThemeByRequest(
        $scenario,
        $result,
        $expressions,
        $deviceHeader
Severity: Major
Found in Test/Unit/Plugin/Magento/Framework/View/DesignExceptionsTest.php - About 2 hrs to fix

    Method testAfterGetThemeByRequestDataProvider has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function testAfterGetThemeByRequestDataProvider()
    {
        $return = [
            [
                'result_not_false', // scenario
    Severity: Minor
    Found in Test/Unit/Plugin/Magento/Framework/View/DesignExceptionsTest.php - About 1 hr to fix

      Function afterGetThemeByRequest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function afterGetThemeByRequest( // @codingStandardsIgnoreLine because of unused $subject
        \Magento\Framework\View\DesignExceptions $subject,
        $result
    ) {
        if ($result === false) {
      Severity: Minor
      Found in src/Plugin/Magento/Framework/View/DesignExceptions.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ScopeConfigInterface $scopeConfig,
        RequestInterface $request,
        Unserialize $unserialize,
        $exceptionConfigPath,
        $scopeType
      Severity: Minor
      Found in src/Plugin/Magento/Framework/View/DesignExceptions.php - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language