Sign upLogin

simongregory/glued

View on GitHub
Star

Showing 4 of 4 total issues

Method make_bootstrap_box has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def make_bootstrap_box(header)
    # 2.11.2 Bootstrap Info box
    b                        = BootstrapBox.new
    b.header                 = header
    b.version                = @reader.byte
Severity: Minor
Found in lib/glued/bootstrap.rb - About 1 hr to fix

    Method make_bootstrap_box has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def make_bootstrap_box(header)
    # 2.11.2 Bootstrap Info box
    b                        = BootstrapBox.new
    b.header                 = header
    b.version                = @reader.byte
    Severity: Minor
    Found in lib/glued/bootstrap.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method download has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def download(url)
    file_name = url.split('/').pop

    dl = fetch_and_report(url)
    Severity: Minor
    Found in lib/glued/grabber.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def initialize(url, data)
    xml = Nokogiri::XML(data)

    namespace = xml.root.namespace.href rescue 'not found'
    fail "Invalid manifest namespace. It was #{namespace} but should have been #{NAMESPACE}" unless namespace == NAMESPACE
    Severity: Minor
    Found in lib/glued/f4m.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language