Sign upLogin

simonmittag/jabba

View on GitHub
Star
jwt.go

Summary

Maintainability
D
1 day
Test Coverage
B
82%

Method Jwt.parseKey has a Cognitive Complexity of 49 (exceeds 20 allowed). Consider refactoring.
Wontfix

func (jwt *Jwt) parseKey(alg jwa.SignatureAlgorithm) error {
    var p *pem.Block
    var p1 []byte
    var err error
Severity: Minor
Found in jwt.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Jwt.LoadJwks has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
Confirmed

func (jwt *Jwt) LoadJwks() error {
    var err error

    //acquires the lock with true else skips
    if jwt.lock.TryAcquire(1) {
Severity: Minor
Found in jwt.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Jwt.parseKey has 115 lines of code (exceeds 50 allowed). Consider refactoring.
Wontfix

func (jwt *Jwt) parseKey(alg jwa.SignatureAlgorithm) error {
    var p *pem.Block
    var p1 []byte
    var err error
Severity: Major
Found in jwt.go - About 3 hrs to fix

    Method Jwt.Validate has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
    Confirmed

    func (jwt *Jwt) Validate() error {
    var err error
    alg := *new(jwa.SignatureAlgorithm)
    err = alg.Accept(jwt.Alg)
    Severity: Minor
    Found in jwt.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Jwt.LoadJwks has 75 lines of code (exceeds 50 allowed). Consider refactoring.
    Confirmed

    func (jwt *Jwt) LoadJwks() error {
    var err error

    //acquires the lock with true else skips
    if jwt.lock.TryAcquire(1) {
    Severity: Minor
    Found in jwt.go - About 2 hrs to fix

      Method Jwt.Validate has 68 lines of code (exceeds 50 allowed). Consider refactoring.
      Confirmed

      func (jwt *Jwt) Validate() error {
    var err error
    alg := *new(jwa.SignatureAlgorithm)
    err = alg.Accept(jwt.Alg)
      Severity: Minor
      Found in jwt.go - About 1 hr to fix

        Method Jwt.Validate has 8 return statements (exceeds 4 allowed).
        Wontfix

        func (jwt *Jwt) Validate() error {
    var err error
    alg := *new(jwa.SignatureAlgorithm)
    err = alg.Accept(jwt.Alg)
        Severity: Major
        Found in jwt.go - About 50 mins to fix

          Method Jwt.UnmarshalJSON has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
          Open

          func (j *Jwt) UnmarshalJSON(data []byte) error {
    var value interface{}
    if err := json.Unmarshal(data, &value); err != nil {
        return err
    }
          Severity: Minor
          Found in jwt.go - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Confirmed

                              switch alg {
                    case jwa.RS256, jwa.RS384, jwa.RS512, jwa.PS256, jwa.PS384, jwa.PS512:
                        k := KidPair{
                            Kid: key.KeyID(),
                            Key: &rsa.PublicKey{
          Severity: Major
          Found in jwt.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Wontfix

                                if err == nil {
                        jwt.ECDSAPublic.Upsert(
                            KidPair{
                                Kid: fmt.Sprintf("%s-%s", alg, uuid.New()),
                                Key: parsed,
            Severity: Major
            Found in jwt.go - About 45 mins to fix

              Function NewJwt has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Confirmed

              func NewJwt(name string, alg string, key string, jwksUrl string, acceptableSkewSeconds string, claims ...string) *Jwt {
              Severity: Minor
              Found in jwt.go - About 45 mins to fix

                Method Jwt.parseKey has 6 return statements (exceeds 4 allowed).
                Wontfix

                func (jwt *Jwt) parseKey(alg jwa.SignatureAlgorithm) error {
    var p *pem.Block
    var p1 []byte
    var err error
                Severity: Major
                Found in jwt.go - About 40 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Invalid

                                  switch key.(type) {
                case *ecdsa.PublicKey:
                    parsed := key.(*ecdsa.PublicKey)
                    err = jwt.checkECDSABitSize(alg, parsed)
                    if err == nil {
                  Severity: Minor
                  Found in jwt.go and 1 other location - About 1 hr to fix
                  jwt.go on lines 404..417

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 129.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Invalid

                              switch pub.(type) {
            case *ecdsa.PublicKey:
                parsed := pub.(*ecdsa.PublicKey)
                err = jwt.checkECDSABitSize(alg, parsed)
                if err == nil {
                  Severity: Minor
                  Found in jwt.go and 1 other location - About 1 hr to fix
                  jwt.go on lines 424..437

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 129.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Invalid

                              switch pub.(type) {
            case *rsa.PublicKey:
                jwt.RSAPublic.Upsert(
                    KidPair{
                        Kid: fmt.Sprintf("%s-%s", alg, uuid.New()),
                  Severity: Minor
                  Found in jwt.go and 1 other location - About 30 mins to fix
                  jwt.go on lines 365..374

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Invalid

                                  switch key.(type) {
                case *rsa.PublicKey:
                    jwt.RSAPublic.Upsert(
                        KidPair{
                            Kid: fmt.Sprintf("%s-%s", alg, uuid.New()),
                  Severity: Minor
                  Found in jwt.go and 1 other location - About 30 mins to fix
                  jwt.go on lines 349..358

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status